Closed
Bug 475837
Opened 12 years ago
Closed 11 years ago
Remove unused member variables "mDictionary" and "mIgnoreList" from spell-checker code
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
2.04 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In working on a followup-patch for bug 461047, I ran across two member-variables in the spell-checking code that are declared but never used. I'm attaching a patch to remove them. (The patch also removes the '#include "nsTArray.h"' that was added very recently in bug 461047, when one of these obsolete variables was upgraded from a nsStringArray a nsTArray<nsString>.)
Assignee | ||
Comment 1•12 years ago
|
||
Here's a MXR search demonstrating that mozSpellChecker::mIgnoreList isn't used anywhere: http://mxr.mozilla.org/mozilla-central/search?string=mIgnoreList And here's a MXR search demonstrating that mozPersonalDictionary::mDictionary isn't used anywhere: http://mxr.mozilla.org/mozilla-central/search?string=[^a-zA-Z]mDictionary[^a-zA-Z]®exp=on&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central (that search uses a regexp to avoid false-positives like "RemoveWordFromDictionary" and "mDictionaryList") The latter search shows that mozHunspell.cpp does use a member variable named mDictionary, but that member variable is declared in mozHunspell.h -- it's not using the one declared in mozPersonalDictionary.h.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dholbert
Assignee | ||
Updated•12 years ago
|
Severity: normal → minor
Assignee | ||
Updated•11 years ago
|
Attachment #359403 -
Flags: review?(Olli.Pettay)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [build_warning]
Updated•11 years ago
|
Attachment #359403 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/661a75f69012
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•