Closed Bug 475837 Opened 12 years ago Closed 11 years ago
Remove unused member variables "m
Dictionary" and "m Ignore List" from spell-checker code
In working on a followup-patch for bug 461047, I ran across two member-variables in the spell-checking code that are declared but never used. I'm attaching a patch to remove them. (The patch also removes the '#include "nsTArray.h"' that was added very recently in bug 461047, when one of these obsolete variables was upgraded from a nsStringArray a nsTArray<nsString>.)
Here's a MXR search demonstrating that mozSpellChecker::mIgnoreList isn't used anywhere: http://mxr.mozilla.org/mozilla-central/search?string=mIgnoreList And here's a MXR search demonstrating that mozPersonalDictionary::mDictionary isn't used anywhere: http://mxr.mozilla.org/mozilla-central/search?string=[^a-zA-Z]mDictionary[^a-zA-Z]®exp=on&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central (that search uses a regexp to avoid false-positives like "RemoveWordFromDictionary" and "mDictionaryList") The latter search shows that mozHunspell.cpp does use a member variable named mDictionary, but that member variable is declared in mozHunspell.h -- it's not using the one declared in mozPersonalDictionary.h.
Attachment #359403 - Flags: review?(Olli.Pettay)
Attachment #359403 - Flags: review?(Olli.Pettay) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.