475837 - Remove unused member variables "mDictionary" and "mIgnoreList" from spell-checker code

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: patch v1

In working on a followup-patch for bug 461047, I ran across two member-variables in the spell-checking code that are declared but never used.

I'm attaching a patch to remove them.  (The patch also removes the '#include "nsTArray.h"' that was added very recently in bug 461047, when one of these obsolete variables was upgraded from a nsStringArray a nsTArray<nsString>.)

Comment 1

[Daniel Holbert [:dholbert]]

Here's a MXR search demonstrating that mozSpellChecker::mIgnoreList isn't used anywhere:
http://mxr.mozilla.org/mozilla-central/search?string=mIgnoreList

And here's a MXR search demonstrating that mozPersonalDictionary::mDictionary isn't used anywhere:
http://mxr.mozilla.org/mozilla-central/search?string=[^a-zA-Z]mDictionary[^a-zA-Z]&regexp=on&case=on&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
(that search uses a regexp to avoid false-positives like "RemoveWordFromDictionary" and "mDictionaryList")

The latter search shows that mozHunspell.cpp does use a member variable named mDictionary, but that member variable is declared in mozHunspell.h -- it's not using the one declared in mozPersonalDictionary.h.

Comment 2

[Daniel Holbert [:dholbert]]

Landed: http://hg.mozilla.org/mozilla-central/rev/661a75f69012