Closed
Bug 475885
Opened 16 years ago
Closed 16 years ago
Error compiling uninstaller - StrCpy expects 2-4 parameters, got 6. in CreateShortcutsLog
Categories
(Firefox :: Installer, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 3.1b3
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
998 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
found while testing bug 475100... ${BrandFullName} needs to be quoted.
Requesting blocking since we are going to need this for branding.
mconnor, can I get you to review this (it is an extremely simple / safe patch)?
Flags: blocking-firefox3.1?
Attachment #359468 -
Flags: review?(mconnor)
|
Assignee | |
Comment 1•16 years ago
|
||
Can't add the Beta string in the installer without this fix so P1.
Priority: -- → P1
Target Milestone: --- → Firefox 3.1b3
|
||
Updated•16 years ago
|
Attachment #359468 -
Flags: review?(mconnor) → review+
|
|
||
Updated•16 years ago
|
Flags: blocking-firefox3.1? → blocking-firefox3.1+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/09abc2219520
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90f859401df9
You need to log in
before you can comment on or make changes to this bug.
Description
•