The shell makefile does not add -DMOZ_SHARK to CFLAGS/CXXFLAGS if MOZ_SHARK is defined

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
10 years ago
8 months ago

People

(Reporter: gal, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
This is what the makefile should look like:

ifdef MOZ_SHARK
CFLAGS += -DMOZ_SHARK -F/System/Library/PrivateFrameworks
CXXFLAGS += -DMOZ_SHARK -F/System/Library/PrivateFrameworks
LDFLAGS += -F/System/Library/PrivateFrameworks -framework CHUD
endif

This is what it looks like:

ifdef MOZ_SHARK
CFLAGS += -F/System/Library/PrivateFrameworks
CXXFLAGS += -F/System/Library/PrivateFrameworks
LDFLAGS += -F/System/Library/PrivateFrameworks -framework CHUD
endif
It gets AC_DEFINEd in configure, which is how it ought to work:
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#4291
(Reporter)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.