Closed Bug 475923 Opened 16 years ago Closed 9 years ago

The shell makefile does not add -DMOZ_SHARK to CFLAGS/CXXFLAGS if MOZ_SHARK is defined

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gal, Unassigned)

Details

This is what the makefile should look like:

ifdef MOZ_SHARK
CFLAGS += -DMOZ_SHARK -F/System/Library/PrivateFrameworks
CXXFLAGS += -DMOZ_SHARK -F/System/Library/PrivateFrameworks
LDFLAGS += -F/System/Library/PrivateFrameworks -framework CHUD
endif

This is what it looks like:

ifdef MOZ_SHARK
CFLAGS += -F/System/Library/PrivateFrameworks
CXXFLAGS += -F/System/Library/PrivateFrameworks
LDFLAGS += -F/System/Library/PrivateFrameworks -framework CHUD
endif
It gets AC_DEFINEd in configure, which is how it ought to work:
http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#4291
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.