475930 - Improvements to protocol registration

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

Currently an application that handles a protocol scheme needs to call nsIPlatformGlue.registerProtocolHandler every time it runs. This is because the factory has to be registered with Mozilla and the callback (if any) needs to be set. There are a number of problems with this. For one thing, the application doesn't necessarily know whether it should be registering or not (e.g. if the registration is triggered by some user action). Also, on Vista this causes an alert to come up since the registry has to be changed every time.

I think the correct solution is to have Prism go ahead and register the protocol factory with Mozilla automatically. The callback should be set using a separate API that can be safely called on each run. The app doesn't need to check whether to register the callback since doing so when the protocol handler isn't registered is a noop anyway.

Comment 1

[Matthew Gertner]

Attachment: Separate APIs for registering protocol and callback, automatically register protocol factory

Comment 2

[Matthew Gertner]

Attachment: Sorry for bug spam, small typo in previous patch (aesthetic effect only but still)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 359500 [details] [diff] [review]
Sorry for bug spam, small typo in previous patch (aesthetic effect only but still)

Needs documentation

Comment 4

[Matthew Gertner]

Sending        runtime/components/public/nsIPlatformGlue.idl
Sending        runtime/components/src/nsPlatformGlue.js
Transmitting file data ..
Committed revision 21920.