475948 - Windows updates (from 29th Jan) pointed at 3.1a1pre builds

Status: RESOLVED WONTFIX

(Mozilla Messaging Graveyard :: Release Engineering, defect)

Description

[Mark Banner (:standard8)]

Somehow the new trunk builds have pointed 3.0b2pre users at 3.1a1pre builds.

This is as a result of the new trunk builds being enabled to upload data to aus.

Comment 1

[Philippe M. Chiasson (:gozer)]

Looking at /opt/aus2/build/0/Thunderbird/trunk/WINNT_x86-msvc/20090129051117/en-US/complete.txt

== BEGIN ==
complete
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2009/01/2009-01-29-05-comm-central-trunk/thunderbird-3.1a1pre.en-US.win32.complete.mar
sha1
a877f4152d8471ff949ef01fb4061f1d73d68295
9970160
20090129051117
3.1a1pre
3.1a1pre
== END ==

Looks fine, and if I read this correctly, it should be an update from 3.1a1pre to 3.1a1pre only, no ?

Comment 2

[Philippe M. Chiasson (:gozer)]

I suspect we are caught by:

// This hash defines the product->version->patch relationships for nightlies
// It determines which patches are associated to which incoming client versions.
// @todo replace this with a better datasource that can be easily managed via a GUI.
$productBranchVersions = array(
    [...]
    'Thunderbird' =>  array(
        '1.5.0.*' =>  '1.5.0.x',
        '2.0*'    =>  '2.0',
        '3.0a*'   =>  'trunk'
    ),

Comment 3

[Mark Banner (:standard8)]

The two update urls are:

https://aus2.mozilla.org/update/3/Thunderbird/3.0b2pre/20090128051621/WINNT_x86-msvc/en-US/nightly/Windows_NT%206.0/default/default/update.xml

gives:

<?xml version="1.0"?>
<updates>
    <update type="minor" version="3.1a1pre" extensionVersion="3.1a1pre" buildID="20090129051117">
        <patch type="complete" URL="http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2009/01/2009-01-29-05-comm-central-trunk/thunderbird-3.1a1pre.en-US.win32.complete.mar" hashFunction="sha1" hashValue="a877f4152d8471ff949ef01fb4061f1d73d68295" size="9970160"/>
    </update>
</updates>

https://aus2.mozilla.org/update/3/Thunderbird/3.1a1pre/20090128051621/WINNT_x86-msvc/en-US/nightly/Windows_NT%206.0/default/default/update.xml

gives:

<?xml version="1.0"?>
<updates>
</updates>

Comment 4

[Philippe M. Chiasson (:gozer)]

Just renamed thunderbird-3.1a1pre.en-US.win32.complete.mar to break the update at least

Comment 5

[Philippe M. Chiasson (:gozer)]

Attachment: AUS config.php patch for comm-central/comm-1.9.1 split

Here is the suggested config.php split between comm-central (trunk) and comm-1.9.1 (3.0) for nightly updates.

Comment 6

[Philippe M. Chiasson (:gozer)]

Attachment: Buildbot: split nightly updates between comm-central/comm-1.9.1

And here is the matching buildbot config.py change to split the nightly updates out.

Comment 7

[Reed Loden [:reed]]

Comment on attachment 359522 [details] [diff] [review]
AUS config.php patch for comm-central/comm-1.9.1 split

Can you file a separate AUS patch for this under the AUS product?

Comment 8

[Philippe M. Chiasson (:gozer)]

Comment on attachment 359522 [details] [diff] [review]
AUS config.php patch for comm-central/comm-1.9.1 split

Filed AUS bug 476013.

Comment 9

[Philippe M. Chiasson (:gozer)]

Pushed first half of attachment 359523 [details] [diff] [review] so tonight's trunk nightlies will end up elsewhere.

changeset:   708:7ff578695b67
tag:         tip
user:        Philippe M. Chiasson <[e-mail]>
date:        Thu Jan 29 15:29:31 2009 -0500
summary:     Bug 475948. Make sure trunk nightly updates go somewhere different. r=me

Comment 10

[Philippe M. Chiasson (:gozer)]

I've also made a comm-1.9.1 symlink to trunk on the AUS area, so when we do switch 1.9.1 builds to upload to comm-1.9.1, we won't lose all the older ones.

-bash-3.2$ cd /opt/aus2/build/0/Thunderbird/
-bash-3.2$ ln -s trunk comm-1.9.1
-bash-3.2$ ls -lort
total 8
drwxrwxr-x 5 tbirdbld 4096 Sep 30  2007 2.0
drwxrwxr-x 5 tbirdbld 4096 Sep 30  2007 trunk
lrwxrwxrwx 1 cltbld      5 Jan 29 12:34 comm-1.9.1 -> trunk

Once the code is all in place, we can just get rid of trunk
 rm comm-1.9.1 && mv trunk comm-1.9.1

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

It's unlikely that bug 476013 will be fixed in a day, so you should set 
  BRANCHES['comm-central-trunk']['create_snippet'] = False
to prevent mar or snippet upload for those nighties.

Comment 12

[Michael Morgan [:morgamic]]

What's up with the AUS patch?  No review needed anymore?

Comment 13

[Philippe M. Chiasson (:gozer)]

(In reply to comment #12)
> What's up with the AUS patch?  No review needed anymore?

Moved it to bug 476013 as recommended by reed in comment #7

Comment 14

[Philippe M. Chiasson (:gozer)]

(In reply to comment #11)
> It's unlikely that bug 476013 will be fixed in a day, so you should set 
>   BRANCHES['comm-central-trunk']['create_snippet'] = False
> to prevent mar or snippet upload for those nighties.

Instead, I've changed where they go and I am shipping them to comm-central/ instead of trunk/, a location AUS simply doesn't know about yet.

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

The symlink in comment #10 means they end up in the same location as the comm-1.9.1, and you'll get a repeat of today's accidental updates.

Comment 16

[Philippe M. Chiasson (:gozer)]

Nope, because the trunk builds will now be going to comm-central/ starting tonight, so they will stay out of the way. Shouldn't they ?

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Ah I missed that you were deprecating /opt/aus2/build/0/Thunderbird/trunk for two new dirs, sorry.

Comment 18

[Philippe M. Chiasson (:gozer)]

Closing, as this will not be necessary, as trunk builds will be posting to our very own AUS.