476057 - Some entries in remora addons table have trailing CRLF in guid field

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Daniel Einspanjer [:dre] [:deinspanjer]]

SELECT * FROM addons WHERE guid LIKE '%\n' -- you might need '%\\n' depending on client

A way to fix them up:

SELECT guid, ASCII(RIGHT(guid, 2)), ASCII(RIGHT(guid, 1))
, ASCII(RIGHT(TRIM(TRAILING '\r\n' FROM guid), 2)), ASCII(RIGHT(TRIM(TRAILING '\r\n' FROM guid), 1))
FROM `addons` WHERE guid LIKE '%\n'

Comment 1

[Aravind Gottipati [:aravind]]

happy to run whatever clouserw approves.

Comment 2

[Wil Clouser [:clouserw]]

Er, I didn't know this was an IT bug.  Sorry Aravind, but moving this to AMO.

Comment 3

[Wil Clouser [:clouserw]]

Daniel:  is the \n coming through in the update ping requests?

I suspect it is not since both add-ons that this affects have "0 active daily users" but one has a decent number of total downloads.  (Which means their updates are currently broken and once I fix this it will fix their updates too).

Just double checking before I change the GUID...

Comment 4

[Daniel Einspanjer [:dre] [:deinspanjer]]

I haven't grepped through logs to try to find them.  I honestly don't know what would happen to the browser when it tried to pass this guid through as a variable.

I can do a search for them next week after we are up and running.

Sorry I logged it as an IT bug because I thought it would need to go into mozilla.org Server operation rather than AMO.  The description of AMO in bugzilla seemed to indicate it pertained only to the website.

Comment 5

[Wil Clouser [:clouserw]]

I installed the add-on and tried it.  Looks like the \n gets trimmed before requesting the update.

This happens because the install.rdf file has a \n in it (bug 444136 should fix that).

Since update requests we're broken I went ahead and changed this in the database for both add-ons, 4413 and 4428.

Comment 6

[Daniel Einspanjer [:dre] [:deinspanjer]]

Just to make sure, did you remove both the \r and \n?

Comment 7

[Wil Clouser [:clouserw]]

yep

Comment 8

[Wil Clouser [:clouserw]]

mysql> select id,guid from addons where id in (4413,4428);
+------+----------------------------------------+
| id   | guid                                   |
+------+----------------------------------------+
| 4413 | {508d8024-bf44-46ae-b5d9-fb61f1694ca3} | 
| 4428 | {CCC7A248-DECB-4c9c-A209-01B787A6A43B} | 
+------+----------------------------------------+
2 rows in set (0.03 sec)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, clouserw; verified per comment 8.