Hulu has a really nice feature that lets you log in from any page on the site from the toolbar. This seems really useful and since there is no reason that i can see against us doing this and bug 475063 removes the login from the homepage I think this is both useful and a nice fix lack of login form on the homepage. This login should bring users back to whatever page they were on before.
Summary: Allow users to log-in and request password resets from toolbar → Allow users to log-in from toolbar
Created attachment 359702 [details] [diff] [review] Patch v1
Attachment #359702 - Flags: review?(mkanat)
decided to do it this way b/c i realized there wasn't a nice way to include "forgot password". Let me know if you think of anything.
Created attachment 359703 [details] Screen Shot Not sure i like how this looks but i thought I'd play around with the idea.
Could we do it AJAX, too, since all we're doing is issuing cookies? I suppose it wouldn't change the current page, though, so we'd probably better just reload. Can we put the form in both the header and footer? I really like how this looks, by the way. But what's the X for?
(In reply to comment #4) > Could we do it AJAX, too, since all we're doing is issuing cookies? I suppose > it wouldn't change the current page, though, so we'd probably better just > reload. Yup exactly what you said. > > Can we put the form in both the header and footer? It already is. You click "login" to make it appear however, i could just get rid of that part. > > I really like how this looks, by the way. But what's the X for? The x is for turning it back into the login text, again we can just always have it up there i just was unsure about the width of the page since the logged out page JUST so happens to be wide enough to support 800 by 600 Let me know if you want me to change the need to click the login.
Oh also i realized with this change I NEED to add a forgot password link to the page as well and I'm struggling where to put it if you all have any ideas. I also fixed that bug that said the forgot login page was unclear, so make sure to check that bug out as well!
(In reply to comment #5) > Let me know if you want me to change the need to click the login. Yeah, let's just have the form be visible. (In reply to comment #6) > Oh also i realized with this change I NEED to add a forgot password link to the > page as well and I'm struggling where to put it if you all have any ideas. Perhaps you could put it into the error message that happens when somebody puts in a bad password? It's not ideal, but it at least keeps it accessible somewhere.
Attachment #359702 - Flags: review?(mkanat) → review-
Created attachment 361914 [details] [diff] [review] V2
Attachment #361914 - Flags: review?(mkanat) → review-
Created attachment 361932 [details] [diff] [review] V3 of patch
Attachment #361932 - Flags: review?(mkanat) → review-
Created attachment 361938 [details] [diff] [review] v4
Comment on attachment 361938 [details] [diff] [review] v4 >Index: template/en/default/account/auth/login-small.html.tmpl >+[% IF cgi.request_method == "GET" AND cgi.query_string %] >+ [% target = target _ "?" _ cgi.query_string %] > [% END %] cgi.url can do that for you, you don't need that block. Everything else *looks* good. (And remove that wrong patch that I mentioned on IM.)
Created attachment 361940 [details] [diff] [review] V5
Created attachment 361942 [details] [diff] [review] V6
Created attachment 361943 [details] [diff] [review] v7
RCS file: /cvsroot/mozilla/webtools/bugzilla/js/global.js,v done Checking in js/global.js; /cvsroot/mozilla/webtools/bugzilla/js/global.js,v <-- global.js initial revision: 1.1 done Checking in skins/standard/global.css; /cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v <-- global.css new revision: 1.60; previous revision: 1.59 done Checking in template/en/default/account/auth/login-small.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v <-- login-small.html.tmpl new revision: 1.12; previous revision: 1.11 done Checking in template/en/default/global/common-links.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v <-- common-links.html.tmpl new revision: 1.19; previous revision: 1.18 done Checking in template/en/default/global/header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v <-- header.html.tmpl new revision: 1.62; previous revision: 1.61 done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Added to the release notes for Bugzilla 3.4 in bug 494037.
You need to log in before you can comment on or make changes to this bug.