consolidate makefile cruft for generating automation.py

RESOLVED FIXED in mozilla1.9.2a1

Status

RESOLVED FIXED
10 years ago
10 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
fixed1.9.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 359755 [details] [diff] [review]
create and use build/automation-build.mk

Currently we have three consumers of automation.py in the tree, and they all copy-paste the Makefile logic needed to preprocess it. This is pretty awful. I'd like to make this a lot better, but right now I'll settle for making it not awful. This patch just creates build/automation-build.mk which the various Makefiles can include to generate automation.py. At least this keeps the Makefile cruft in one central location. Oh, also, it moves automation.py.in from build/pgo to build/, because although it's used in the pgo script, that's not its sole purpose.
Attachment #359755 - Flags: review?(benjamin)
Created attachment 359762 [details] [diff] [review]
a slight change

Instead of using $(DIST) at all in the preprocessor bits, make consumers specify a TARGET_DEPTH variable, so they can indicate the depth at which automation.py will get installed to in the objdir.
Assignee: nobody → ted.mielczarek
Attachment #359755 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #359762 - Flags: review?(benjamin)
Attachment #359755 - Flags: review?(benjamin)
Blocks: 468913

Updated

10 years ago
Attachment #359762 - Flags: review?(benjamin) → review+
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/ee4fde1683df
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Whiteboard: [needs 1.9.1 landing] → [needs 1.9.1 landing: after bug 472706]
Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d06c533a8d5d
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing: after bug 472706]

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.