###!!! ASSERTION: Potential deadlock between media.decoderMonitor@2aaabc33eb40 and Lock@2aaabcf2a300: 'Error', file nsAutoLock.cpp, line 318

RESOLVED FIXED

Status

()

Core
Audio/Video
P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: smaug, Assigned: roc)

Tracking

({fixed1.9.1})

Trunk
x86
Linux
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
I get that assertion few times when running mochitest.
The assertion is something quite new.

Comment 1

9 years ago
Created attachment 360165 [details]
Jesse's stack

I hit this while fuzz-testing or something.
Flags: blocking1.9.1+
Priority: -- → P2
This particular stack will be fixed by my patch in bug 455654. But it seems that across the board we should never be holding both locks at the same time.
With bug 455654, I hit this when a video resumes after a stall in sending data...

http://dolske.net/mozilla/tests/video/slowsend.php?rate=100&stallat=1000000&stallfor=15

This plays for a few seconds, pauses for ~15 seconds, and when it starts getting data again I get a few of these asserts. But it seems to keep working.
Created attachment 361235 [details] [diff] [review]
fix

This fixes at least one set of these assertions. We shouldn't call Available() on the stream while holding the decoder lock; we're actually trying to never hold the stream lock at the same time as the decoder lock. We can avoid calling Available altogether by using mDownloadPosition instead, which is protected by the decoder lock.
Assignee: nobody → roc
Attachment #361235 - Flags: review?(chris.double)
Whiteboard: [needs review]

Updated

9 years ago
Attachment #361235 - Flags: review?(chris.double) → review+
Whiteboard: [needs review] → [needs landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/784122b49e33

I'm marking this fixed since we fixed a real bug here. If we hit this assertion again, please file a new bug.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5201bf6ecd27
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.