476185 - runtests.py should print out firefox-bin's stdout immediately

Status: VERIFIED FIXED

(Testing :: Mochitest, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

https://bugzilla.mozilla.org/show_bug.cgi?id=464191#c62

Comment 1

[Serge Gautherie (:sgautherie)]

I see this bug too, on my local Windows 2000.

Comment 2

[Bjarne (:bjarne)]

Attachment: Quick fix to avoid in-built buffering in iterators

The iterator over file-objects has it's own buffering. This patch replaces it with a more primitive loop. On my Ubuntu-system this works nicely with no extra options to python. On other systems, the -u option may have to be used to avoid stdio-buffering.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 362086 [details] [diff] [review]
Quick fix to avoid in-built buffering in iterators

>+  while (line != ""):

Ax the unnecessary parentheses, upload a patch, and I'll push.

Gah, I didn't realize that happened...

Comment 4

[Bjarne (:bjarne)]

Attachment: Removed parentheses... [Checkin: See comment 6 & 13]

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

cool!

Comment 6

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/mozilla-central/rev/87b0a5610a8d

Comment 7

[Jeff Walden [:Waldo]]

Comment on attachment 362092 [details] [diff] [review]
Removed parentheses...
[Checkin: See comment 6 & 13]

For future reference, if a patch receives a + but also has comments to be addressed on it, you can just upload a new version of the patch with the comments addressed and don't have to worry about getting another review of it -- it's a measure of trust/confidence that the changes can be made without a precise lookthrough again to be sure they were made correctly.

Comment 8

[Honza Bambas (:mayhemer)]

I don't see ANY output on Mac.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> I don't see ANY output on Mac.

To be explicit, which check-in caused this ? Comment 6 ?
And which behavior did you get before ?

Comment 10

[Bjarne (:bjarne)]

(In reply to comment #8)
> I don't see ANY output on Mac.

I dont't have access to a Mac at the moment... Is there no output whatsoever? What if you disable this particular patch and keep the one for bug #464191? Did you try running python with the -u option?

Btw, didn't this one land some time ago (ref comment #3 and comment #6)? Did anyone else see this problem?

Comment 11

[Honza Bambas (:mayhemer)]

Guys, my apologies. Debug build works as expected but I was running an optimized build that has no output, I was convinced it had some output in the past but probably never had. Sorry for this spam!

Comment 12

[Bjarne (:bjarne)]

Phew...  I was starting to get worried...    :)

Thanks for clearing it up.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 362092 [details] [diff] [review]
Removed parentheses...
[Checkin: See comment 6 & 13]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/10fb2d2f8535

After fixing context for:
{
patching file build/automation.py.in
Hunk #1 FAILED at 441
1 out of 1 hunks FAILED
}

Comment 14

[Serge Gautherie (:sgautherie)]

V.Fixed, locally.