476209 - refactor test_nsIAccessibleDocument.html

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Might as well use our newish testStates function.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: imports some common scripts, uses nice testStates function

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 359824 [details] [diff] [review]
imports some common scripts, uses nice testStates function

>     var gAccRetrieval = null;
> 
>     function doTest()
>     {
>       gAccRetrieval = Components.classes["@mozilla.org/accessibleRetrieval;1"].
>                       getService(nsIAccessibleRetrieval);
 
All of this is in common.js and is done on load. No need to do it here, in fact it may even mess things up. To retrieve the accessible, simply use the getAccessible(document) function call.

>+        testStates(docAcc, STATE_READONLY);
>+        testStates(docAcc, STATE_FOCUSABLE)

No need to call testStates twice here, just write:
testStates(docAcc, (STATE_READONLY | STATE_FOCUSABLE));

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: addresses Marco's comments

Marco, nice catches, I might as well do more cleanup while I'm here.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 359913 [details] [diff] [review]
addresses Marco's comments

>       // Get accessible for body tag.
>
>       var docAcc = null;
>
>       try {
>
>         docAcc = gAccRetrieval.getAccessibleFor(document).
>
>                  QueryInterface(nsIAccessibleDocument);
>
>       } catch(e) {}
>
>       ok(docAcc, "No accessible with interface for document!");
>
> 

Nit: Use the getAccessible function from common.js instead, and pass in the document element and wanted interfaces as the param. it will do all failure handling for you. Then continue with the if block as you already do.

r=me with that fixed.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch to push

Thanks Marco. I use the getAccessible convenience here.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: better (thanks Marco)

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: Patch to push

Final tweak. Marco, good to push?

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 360109 [details] [diff] [review]
Patch to push

>+      var docAcc = getAccessible(document, [nsIAccessibleDocument])

Missing ; at the end. I'll add that and push.

Comment 9

[Marco Zehe (:MarcoZ)]

Pushed on Davidb's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/764a7cdc905b

Comment 10

[alexander :surkov (:asurkov)]

David, please file similar bugs to Core->Disability Access API (because the component you choosed is for pure Firefox a11y related bugs).