476232 - update check always returns newest/highest version, independent if the add-on is compatible or not to the appVersion (updatecheck, update.rdf, addon, incompatible)

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mossop spotted this:

AMO's update check always returns the newest/highest version, independent if the add-on is compatible or not to the appVersion

https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={9c51bd27-6ed8-4000-a2bf-36cb95c0c947}&version=10.0.3&maxAppVersion=3.2a1pre&status=userEnabled&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=1.5.0.4&appOS=Darwin&appABI=x86-gcc3&locale=en-US&currentAppVersion=1.5.0.4

Returns v10.1.0 which isn't compatible instead of v10.0.3 which is

Keywords:
(updatecheck, update.rdf, addon, incompatible)

Comment 1

[Justin Scott [:fligtar]]

This was done intentionally a while back because of problems with SQL sorting version numbers. It will return the latest version compatible with the client application, regardless of client version number.

Comment 2

[Wil Clouser [:clouserw]]

wontfix from comment 1

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Dave Dash worked on converting version numbers to integer values, has this become product-ready so it could be used for this?

Comment 6

[Dave Garrett]

Bug 611551 was fixed so I decided to give this a test. I installed Flagfox 3.3.20 in Firefox 3.0, then tried to update it. Just a little while ago, no update was available because current Flagfox 4.1.0 is not compatible with Firefox 3.0. This time it let me update to Flagfox 4.0.14, the last available version compatible with Firefox 3.0. The testcase in comment 0 is still valid and it too now produces the correct result: it now returns version 10.0.3 instead of the current version 11.0.1.

WONTFIX -> FIXED!

Comment 7

[Dave Garrett]

(Actually, now I'm not sure if it was bug 611551 or another, as I'm not sure that is live on production yet. Please correct me if it was fixed in another bug. Regardless, this bug is fixed now.)