Closed Bug 476279 Opened 11 years ago Closed 11 years ago

Incomplete Header in Account Settings - Security

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: williejreid, Assigned: philor)

References

Details

(Keywords: regression)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090130 SeaMonkey/2.0a3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090130 Shredder/3.1a1pre

Open Account Settings and select Security. The header is shortened, preceded with the code orient="vertical">
Happens in all accounts and with fresh new profile containing one account.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
This is not a Forum and Forum-Codes doesn't work here. Either just post the URL as comment without addong additional Codes or better add it in the URL field of the bug or the best thing is to attach it as attachment
Component: General → Account Manager
QA Contact: general → account-manager
Oops! Sorry. Thanks for doing it for me.
The fun part is that it's a regression from bug 278549, which landed last June, but apparently that stray bit of content in http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/extensions/smime/resources/content/am-smime.xul&rev=1.18&mark=51#51 doesn't actually show in 1.9.1, only in 1.9.2 (which, Willie, did you really intend to be using 3.1a1pre rather than 3.0b3pre, or did you get caught by the accidental update Thursday and you haven't yet downloaded a 3.0 nightly to get back?).
Assignee: nobody → philringnalda
Blocks: 278549
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: regression
OS: Windows XP → All
Hardware: x86 → All
Version: unspecified → Trunk
Well, I've actually been running both and yes, it didn't show in 1.9.1
Attached patch Remove 'emSplinter Review
I'm not quite sure just what a <page orient="vertical"> is, but since we've done without this one being vertical for seven months now, and since most of the am-*.xuls had their orient="vertical" removed by Blake in some 2001 XUL syntax change megapatch, I'm pretty sure we'll get by without these two.
Attachment #359970 - Flags: superreview?(neil)
Attachment #359970 - Flags: review?(neil)
Attachment #359970 - Flags: superreview?(neil)
Attachment #359970 - Flags: superreview+
Attachment #359970 - Flags: review?(neil)
Attachment #359970 - Flags: review+
Comment on attachment 359970 [details] [diff] [review]
Remove 'em

<page orient="vertical"> is like <vbox orient="vertical">.

The reason the spurious text appears on trunk is that the layout team have been simplifying the code incidentally removing many of the special cases that apply to XUL; in this particular case the case was that XUL used to ignore random text nodes.
http://hg.mozilla.org/comm-central/rev/c550e59d094e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.