476279 - Incomplete Header in Account Settings - Security

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Willie Reid]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090130 SeaMonkey/2.0a3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090130 Shredder/3.1a1pre

Open Account Settings and select Security. The header is shortened, preceded with the code orient="vertical">
Happens in all accounts and with fresh new profile containing one account.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Willie Reid]

[URL=http://img218.imageshack.us/my.php?image=accountsettingses6.jpg][IMG]http://img218.imageshack.us/img218/4676/accountsettingses6.th.jpg[/IMG][/URL]

Comment 2

[Matthias Versen [:Matti]]

Attachment: Screenshot ffrom the reporter

This is not a Forum and Forum-Codes doesn't work here. Either just post the URL as comment without addong additional Codes or better add it in the URL field of the bug or the best thing is to attach it as attachment

Comment 3

[Willie Reid]

Oops! Sorry. Thanks for doing it for me.

Comment 4

[Phil Ringnalda (:philor)]

The fun part is that it's a regression from bug 278549, which landed last June, but apparently that stray bit of content in http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/extensions/smime/resources/content/am-smime.xul&rev=1.18&mark=51#51 doesn't actually show in 1.9.1, only in 1.9.2 (which, Willie, did you really intend to be using 3.1a1pre rather than 3.0b3pre, or did you get caught by the accidental update Thursday and you haven't yet downloaded a 3.0 nightly to get back?).

Comment 5

[Willie Reid]

Well, I've actually been running both and yes, it didn't show in 1.9.1

Comment 6

[Phil Ringnalda (:philor)]

Attachment: Remove 'em

I'm not quite sure just what a <page orient="vertical"> is, but since we've done without this one being vertical for seven months now, and since most of the am-*.xuls had their orient="vertical" removed by Blake in some 2001 XUL syntax change megapatch, I'm pretty sure we'll get by without these two.

Comment 7

[[e-mail]]

Comment on attachment 359970 [details] [diff] [review]
Remove 'em

<page orient="vertical"> is like <vbox orient="vertical">.

The reason the spurious text appears on trunk is that the layout team have been simplifying the code incidentally removing many of the special cases that apply to XUL; in this particular case the case was that XUL used to ignore random text nodes.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/c550e59d094e