Closed
Bug 476295
Opened 15 years ago
Closed 15 years ago
Bug 284320 created an unused variable (aPresContext) in layout/generic/nsFrameFrame.cpp
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: GPHemsley, Assigned: GPHemsley)
References
Details
Attachments
(1 file)
|
1010 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Bug 284320 removed code from layout/generic/nsFrameFrame.cpp that used the variable aPresContext. That was the only usage of the variable, but it was not removed in the patch. As such, the variable declaration has been orphaned.
|
Assignee | |
Comment 1•15 years ago
|
||
This patch removes the orphaned variable.
Attachment #359939 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #359939 -
Flags: superreview?(bzbarsky)
Attachment #359939 -
Flags: review?(bzbarsky)
Attachment #359939 -
Flags: review?
|
||
Comment 2•15 years ago
|
||
Comment on attachment 359939 [details] [diff] [review] Remove unused variable aPresContext Good catch.
Attachment #359939 -
Flags: superreview?(bzbarsky)
Attachment #359939 -
Flags: superreview+
Attachment #359939 -
Flags: review?(bzbarsky)
Attachment #359939 -
Flags: review+
|
|
||
Updated•15 years ago
|
Assignee: nobody → gphemsley
|
|
||
Comment 3•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/59f04c021bb8 Thanks for the patch!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•