Created attachment 360014 [details] [diff] [review] proposed fix For pinstripe we have message-mail-attach-del.gif, for other themes attachment-deleted.png. Unfortunately we try to show message-mail-attach-del.png so all three themes are missing an icon for deleted attachments atm. I think this used to work in 1.5, or there about... Converted the pinstripe icon to png and renamed it to have the same name as qute/gnomestripe. FWIW, seamonkey also have a name mismatch, but they don't use the icon it seems: http://mxr.mozilla.org/comm-central/search?string=message-mail-attach-del&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
You have mailnews.attachments.display.largeView set to false, don't you? Is there anything prettier we can do than to just have two icons, a 16x16 and a 32x32? (And a 32x32 that will probably be from you just resizing them in the GIMP, including that just-plain-wrong pinstripe one, which is not at all a document-looking-thing with the pinstripe delete overlaid on it - are we going to hire a contract icon designer, and/or drum up some volunteer icon designers, and have a Tb: Theme component where we can put his/their bugs?)
(In reply to comment #1) > You have mailnews.attachments.display.largeView set to false, don't you? Ah yes... > Is there anything prettier we can do than to just have two icons, a 16x16 and a > 32x32? I don't know, but suggestions welcome.
The closest thing I had to an idea was using the moz-icon:// image with the toolbar delete button's image overlaid, but the odds of that being either pretty, or robust, don't strike me as very good.
Created attachment 361142 [details] [diff] [review] proposed fix, v2 The icons didn't stretch to 32x32 very well, so I made new ones (will attach a qute/gnomestripe screenshot). For pinstripe I agree the icons were a bit odd, so I made new ones there too. People can certainly feel free to submit better ones.
Created attachment 361208 [details] screenshot - v2 - pinstripe So, about that icon designer we were going to hire or recruit...?
Comment on attachment 361142 [details] [diff] [review] proposed fix, v2 r=me with your qute/gnomestripe icons copied into pinstripe, too: I appreciate the effort, which was better than I would do, but the gnomestripe ones are a whole lot prettier, and we don't really need to match the toolbar delete button if we're planning on taking it out of the default set anyway.
Copied over the icons to pinstripe, and checked in. changeset: 1903:9d9f7e7a1b18 http://hg.mozilla.org/comm-central/rev/9d9f7e7a1b18 ->FIXED