476413 - The Client view is empty if it was deleted at start-up or closed

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[worms]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081010 SeaMonkey/2.0a2pre
Build Identifier: 

If the user sets some channels or networks to connect at start-up, then the client view is not opened. Typing /client to get it makes it open, but it then contains no messages at all (no networks list, no help links...)
The same happens if the *client* view was closed after ChatZilla is launched, and is re-opened with /client.

Reproducible: Always

Steps to Reproduce:
1.Set some networks/channels/users to connect at start-up
2.Lauch ChatZilla
3.Type /client to get the *client* view
Actual Results:  
The *client* view is empty.

Expected Results:  
The *client* view should contain the messages it contains when ChatZilla is launched without auto-starting views.

Sugnim++

Comment 1

[James Ross]

Attachment: Fix messages condition and dispatch the same commands as on startup

Seems the old code did try and do this, but the create-tab-for-view was creating client.messages and thus broke the check. No need for that command though, as long as the code does client.display() then /set-current-view.

Comment 2

[:Gijs (he/him)]

Comment on attachment 409520 [details] [diff] [review]
Fix messages condition and dispatch the same commands as on startup

Nit: please also remove msg.client.opened from cz.properties . It does not seem to be used elsewhere.

With that, r=me.

Comment 3

[James Ross]

Checked in with msg.client.opened removed --> FIXED.