Closed
Bug 476521
Opened 15 years ago
Closed 15 years ago
simplify browser.xul styles
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
fennec1.0b1
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 2 obsolete files)
9.30 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
We can use a single selector instead of adding the style inline on each element for the -moz-stack-sizing stuff. Also adds a license header.
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #360147 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 360147 [details] [diff] [review] patch The flex is there so that the stack is sized to the window width by default, but it's not strictly necessary since we'll resize the stack anyways.
Updated•15 years ago
|
Attachment #360147 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•15 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/731f6fc9c130
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Target Milestone: --- → Fennec A3
Assignee | ||
Comment 4•15 years ago
|
||
Backed out, since it might have caused a Ts regression: http://graphs.mozilla.org/#show=2774468,2774466,2774464 https://hg.mozilla.org/mobile-browser/rev/7fc04c681e32
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•15 years ago
|
||
Gavin, are you going to try to land this again or has it bit rotted beyond usefulness?
Assignee | ||
Comment 6•15 years ago
|
||
Still needs landing, just need to figure out which part caused a regression. Just the CSS styling changes alone are probably safe?
Assignee | ||
Comment 7•15 years ago
|
||
If this causes a Ts regression I will eat my hat.
Attachment #360147 -
Attachment is obsolete: true
Assignee | ||
Comment 8•15 years ago
|
||
Attachment #382142 -
Attachment is obsolete: true
Attachment #382144 -
Flags: review?(mark.finkle)
Updated•15 years ago
|
Attachment #382144 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 9•15 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/ace0dda38376
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•