Closed Bug 476537 Opened 11 years ago Closed 2 years ago

Bookmark description field is empty when we add a bookmark by a drag-and-drop to the toolbar

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set

Tracking

()

RESOLVED INACTIVE

People

(Reporter: contact, Unassigned)

Details

(Whiteboard: [FFT3.5])

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.0.5) Gecko/2008121622 Ubuntu/8.10 (intrepid) Firefox/3.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.0.5) Gecko/2008121622 Ubuntu/8.10 (intrepid) Firefox/3.0.5

If I add a bookmark by drag-and-dropping a tab to the toolbar, the description field is empty (it's not filled with the meta-description of the web page).

Reproducible: Always

Steps to Reproduce:
1. Visit any web site, for example http://www.alsacreations.com/
2. Drag-and-drop the tab to the toolbar, so a bookmark is created on the toolbar.
3. Click right on the bookmark and choose "Properties".
Actual Results:  
The description field is empty.

Expected Results:  
The description field should be filled with the meta-description of the page:

Alsacréations, portail communautaire et d'actualités autour de la création web
I have the same bug with a drag-and-drop of the favicon.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090201 Minefield/3.2a1pre

I see this after every drag and drop operation, also to the library.
I can have two identical bookmarks side by side on the toolbar, and the dragged one has no description. This bug has similarities with Bug 435282.
OS: Linux → All
Hardware: x86 → All
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Adding [FFT3.5] in whiteboard.  Came across this issue during RC1 testing
Whiteboard: [FFT3.5]
I think, Since the dragged object might not be the current opened webpage (u can drag a link from the page itself), thus the description field will not be always be filled with the meta-description ...

I dont know if this will help or not, but we can add the following lines of code somehow [In "http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/controller.js" in the onDrop function] to get the meta-description by checking if the dragged URL is equal to the current opened webpage, if true then get the current webpage description

var draggedURL = data.split("\n")[0];
var currentURL = gBrowser.webNavigation.currentURI.spec;
var description = "";
if(draggedURL == currentURL)
{
description = PlacesUIUtils.getDescriptionFromDocument(gBrowser.webNavigation.document);
}
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.