476608 - fix bad use of readlink in commented-out code

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

While I was debugging why my 1.9.0.x build wouldn't start (it turned out to be because I needed http://hg.mozilla.org/mozilla-central/rev/adf33dbb59d0 for it to start on 64-bit Linux), I found a bug in some commented out code that I was trying as a workaround.

The code called readlink and used its result, but |man 2 readlink| will tell you that readlink does not null-terminate the buffer.

This fixes the code, which might make it usable (see the changes to comments).  Not sure if you'd want to use it.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/9c12373aed0a