Closed
Bug 476691
Opened 17 years ago
Closed 17 years ago
Testcase ecma3/Type/e8_5 has incorrect expected values and tamarin is producing them
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: brbaker, Assigned: lhansen)
Details
Attachments
(1 file)
The following 2 tests in the ecma2/Type/e8_5.as testcase have an expected value that is incorrect, and tamarin is producing the incorrect value:
Positive finite Non zero values where e is 971
Negative finite Non zero values where e is 971
Finite nonzero values that are Normalised having the form s*m*2**e where s is +1 or -1, m is a positive integer less than 2**53 but not less than s**52 and e is an integer ranging from -1074 to 971
Postive:
1*(Math.pow(2,52))*(Math.pow(2,971))
spidermonkey: 8.98846567431158e+307
tamarin: 1e+308
Negative:
-1*(Math.pow(2,52))*(Math.pow(2,971))
spidermonkey: -8.98846567431158e+307
tamarin: -e+308
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Updated•17 years ago
|
Assignee: nobody → stejohns
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
| Reporter | ||
Comment 1•17 years ago
|
||
This testcase is unstable on x64, passing and failing intermittently, skipping the test until this is resolved to remove unwanted noise in the build system.
| Assignee | ||
Updated•17 years ago
|
Assignee: stejohns → lhansen
| Assignee | ||
Comment 2•17 years ago
|
||
The tests are unstable because the code works on uninitialized memory in the case of negative values.
| Assignee | ||
Comment 3•17 years ago
|
||
Attachment #360713 -
Flags: review?(stejohns)
Comment 4•17 years ago
|
||
Comment on attachment 360713 [details] [diff] [review]
If working on negative values, skip the uninitialized space set aside for the minus sign when scanning leading zeroes
Yow! Nice find.
Attachment #360713 -
Flags: review?(stejohns) → review+
| Assignee | ||
Comment 5•17 years ago
|
||
redux changeset: 1406:6790439dd3cd
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 6•17 years ago
|
||
removed the skip from the testconfig (1407:0c0f3cf40ad0)
| Reporter | ||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•