476817 - Optional credit for NSIS team in about:licence

Status: VERIFIED FIXED

(mozilla.org :: Licensing, task)

Description

[Gervase Markham [:gerv]]

rstrong writes:

"Would it be possible to add

The Nullsoft Scriptable Install System (Contributors)
with the link pointing to
http://nsis.sourceforge.net/

[to the optional section of about:licence?]

I'd like to also have the string have NSIS in it but it doesn't look like it would fit well with the current format."

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Gerv, are you ok with adding it like so?

Comment 2

[Gervase Markham [:gerv]]

The word "contributors" seems a bit redundant - obviously, the project has contributors, otherwise it wouldn't exist :-) If the project has no BDFL, then let's just list them as you have, without the "(contributors)" text.

Otherwise, this is just what I had in mind.

Gerv

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

comments addressed

There is one person that I consider the lead of the project but as of late they've changed everything to contributors so let's go with this.

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 363528 [details] [diff] [review]
patch rev2

r=gerv.

Gerv

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/d1a389394592

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8746905742b7

Comment 8

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090226 Minefield/3.2a1pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090226 Firefox.