Closed
Bug 476823
Opened 15 years ago
Closed 15 years ago
nsFileSystemDataSource doesn't implement nsISupports
Categories
(Core Graveyard :: RDF, defect)
Core Graveyard
RDF
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: fixed1.9.1, regression, verified1.9.0.9)
Attachments
(1 file)
498 bytes,
patch
|
benjamin
:
review+
benjamin
:
superreview+
beltzner
:
approval1.9.1+
dveditz
:
approval1.9.0.9+
|
Details | Diff | Splinter Review |
... which makes it impossible to use from JS, for instance.
Flags: blocking1.9.1?
Flags: blocking1.9.0.8?
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #360479 -
Flags: superreview?(benjamin)
Attachment #360479 -
Flags: review?(sayrer)
Updated•15 years ago
|
Attachment #360479 -
Flags: superreview?(benjamin)
Attachment #360479 -
Flags: superreview+
Attachment #360479 -
Flags: review?(sayrer)
Attachment #360479 -
Flags: review+
Updated•15 years ago
|
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Wouldn't block, but we'll take the patch. Approving in a sec.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Updated•15 years ago
|
Attachment #360479 -
Flags: approval1.9.1+
Comment 3•15 years ago
|
||
Comment on attachment 360479 [details] [diff] [review] Proposed patch a191=beltzner
Comment 4•15 years ago
|
||
Ditto comment 2 for the 1.9.0 branch.
Flags: blocking1.9.0.8? → wanted1.9.0.x+
Comment 5•15 years ago
|
||
(In reply to comment #4) > Ditto comment 2 for the 1.9.0 branch. So wanted-1.9.0.x twice? :-p
Assignee | ||
Comment 6•15 years ago
|
||
Pushed changeset 3bf7e3fae8bf to mozilla-central. Pushed changeset b746930b1c17 to releases/mozilla-1.9.1
Assignee | ||
Updated•15 years ago
|
Attachment #360479 -
Flags: approval1.9.0.7?
Comment 7•15 years ago
|
||
Comment on attachment 360479 [details] [diff] [review] Proposed patch Although this is brain-dead simple, we are already frozen for 1.9.0.7 and don't want to restart the QA clock. We'll definitely take in 1.9.0.8 once the tree reopens.
Attachment #360479 -
Flags: approval1.9.0.7? → approval1.9.0.8?
Comment 8•15 years ago
|
||
Comment on attachment 360479 [details] [diff] [review] Proposed patch Approved for 1.9.0.8, a=dveditz for release-drivers
Attachment #360479 -
Flags: approval1.9.0.8? → approval1.9.0.8+
Comment 10•15 years ago
|
||
Verified for 1.9.0.8 by looking at source since it is a simple change.
Keywords: fixed1.9.0.8 → verified1.9.0.8
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•