47685 - Editor formatting toolbar buttons have no toggled or disabled styles

Status: VERIFIED FIXED

(Core Graveyard :: Skinability, defect, P3)

Description

[Simon Fraser [no longer active]]

We need style on the editor formatting toolbar buttons for toggled and disbaled.
(Note that modern skin does not have disabled style yet. I have a fix.)

Also, we decided to use 'B', 'I' and 'U'  in the bold, italics and underline 
buttons, instead of A, A and A. Please use those, instead of copying inferior 4.x 
behaviour.

Comment 1

[Blake Ross]

*** Bug 48406 has been marked as a duplicate of this bug. ***

Comment 2

[Nikhil Bhatla (gone)]

Simon, what is your fix to make the disabled-state icons appear in 
composer?  The CSS styles are there in classic EditorToolbars.css, but 
the icons are not appearing for some reason.  I have a feeling that the 
disabled attribute is not getting marked on the bold, underline, italics 
toolbar buttons, but I don't know how this could be.

Comment 3

[Simon Fraser [no longer active]]

The Bold, Italics and Underline buttons never get disabled. If you want to test 
the style, set disabled="true" in the XUL by hand.

Comment 4

[Nikhil Bhatla (gone)]

Why don't these buttons get disabled?  Shouldn't they be disabled when the text
area below them does not have focus, such as on startup of composer?

Comment 5

[Simon Fraser [no longer active]]

Probably. This is more of a controller/focus issue.

Comment 6

[Nikhil Bhatla (gone)]

Well, in light of that, I've made modifications to editorOverlay.xul.  I've
attached a diff, which I've also sent to cmanske.  I'm not a XUL master, and I
don't know if this will cause some unexpedted alternate behavior, but it appears
to work fine.  Simon, can you look over this?  (Note that I've simply added an
'observes="cmd_"' line to each button)

Index: editorOverlay.xul
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/editorOverlay.xul,v
retrieving revision 1.113
diff -r1.113 editorOverlay.xul
808c808
<   <button class="button-toolbar" id="boldButton"
oncommand="goDoCommand('cmd_bold')"
---
>   <button class="button-toolbar" id="boldButton"
oncommand="goDoCommand('cmd_bold')" observes="cmd_bold"
812c812
<   <button class="button-toolbar" id="italicButton" align="center"
oncommand="goDoCommand('cmd_italic')"
---
>   <button class="button-toolbar" id="italicButton" align="center"
oncommand="goDoCommand('cmd_italic')" observes="cmd_italic"
816c816
<   <button class="button-toolbar" id="underlineButton" align="center"
oncommand="goDoCommand('cmd_underline')"
---
>   <button class="button-toolbar" id="underlineButton" align="center"
oncommand="goDoCommand('cmd_underline')" observes="cmd_underline"
821c821
<   <button class="button-toolbar" id="ulButton" oncommand="goDoCommand('cmd_ul')"
---
>   <button class="button-toolbar" id="ulButton"
oncommand="goDoCommand('cmd_ul')"  observes="cmd_ul"
826c826
<   <button class="button-toolbar" id="olButton" oncommand="goDoCommand('cmd_ol')"
---
>   <button class="button-toolbar" id="olButton"
oncommand="goDoCommand('cmd_ol')" observes="cmd_ol"

Comment 7

[Simon Fraser [no longer active]]

If you add observes=, then remove oncommand=

I'm not sure why it's not using observers there now.

Comment 8

[Nikhil Bhatla (gone)]

Submitted toggled states.  Will submit new bold, underline, italic icons 
soon.

Comment 9

[Nikhil Bhatla (gone)]

Submitted new images.  Marking FIXED.

Comment 10

[Blake Ross]

mac --> patty

Comment 11

[Patty Mac]

Fixed in Mac (Build: 2000-09-08-20-M18).