Closed Bug 476932 Opened 15 years ago Closed 15 years ago

in selftest suite avmplus_peephole.st test gives seg fault

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dschaffe, Assigned: lhansen)

References

Details

Attachments

(1 file)

building the shell with selftests and running the peephole test crashes the shell

$ ../configure.py --enable-shell --enable-debug --enable-selftests
...
$ shell/avmshell -Dselftest=avmplus,peephole
['start', 'avmplus', 'peephole']
['test', 'avmplus', 'peephole', 'get2locals']
Segmentation fault

in xcode debugger:
ST_avmplus_peephole.cpp:90    WordcodeEmitter* t = new WordcodeEmitter(core, NULL, opcode_labels);
Program received signal:  “EXC_BAD_ACCESS”.
Flags: flashplayer-triage+
removed the ST_avmplus_peephole.st test temporarily (renamed to _SKIP).
Blocks: 469836
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Attachment #360702 - Flags: review?(dschaffe)
Comment on attachment 360702 [details] [diff] [review]
Fixes the relevant bitrot in the WordcodeEmitter

peephole get2locals test passes in selftests.
Attachment #360702 - Flags: review?(dschaffe) → review+
I'll commit it, rename the _SKIP file back to the original, and regenerate the selftest files and push those too.
redux:
 changeset:   1400:0e62af2d1716 (the fix)
 changeset:   1401:a7e0ac3b9e81 (rename file)
 changeset:   1402:1d0a52aa88cb (regenerate SelftestInit.cpp)
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: