476953 - search box default text doesn't go away/remains - typed search terms overlayed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: search terms and default text overlayed

Sometimes (when I quickly set the focus to the search box at https://addons.mozilla.org/de/firefox/ ?), thesearch box default text doesn't go away/remains and overlays the typed search terms.

Browser: Gecko 1.9.0.6pre and 1.9.0.7pre with Windows XP

Comment 1

[Wil Clouser [:clouserw]]

woah. umm.

The "Suche nach Add-ons" is just pre-filled text that gets deleted by javascript when you click.  Anyway to get text overlapping text in an <input> sounds like a bigger issue no matter when you decide to focus*.  Is there an easy way to reproduce this and is it possible in other browsers?

* If you click before the document is loaded it's possible the text won't be deleted when you start typing.  In this case your new text would be inserted into the old wherever you clicked, not over the top.

Comment 2

[Fred Wenzel [:wenzel]]

I haven't been able to reproduce this, and it may be gone in the new layout. Please let us know if this still occurs.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I still see this with Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

I can reproduce it now:
When the page loads, and the search box is already rendered/shown, quickly click into it, the default text will be added later. (Page loaded with Ctrl+Shift+R).

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Comment 6

[Fred Wenzel [:wenzel]]

There's unfortunately no way to detect if the search box has the focus already, so all we can do is blur() it unless the user has entered some text already (in which case the label doesn't show up anyway).

Anything keeping us from implementing it without a label, like I did on the dev hub? That's beyond the scope here, but I never understood the advantage of that overlaid label.

Comment 7

[Ryan Doherty (:rdoherty)]

I've tried reproducing this and can't, probably due to hosting this locally and the page loads too fast.

I'm all for changing this to not use a label over the input box, always seemed like a weird way to do it. I'd vote for adding an aria role='search' to it while were there ;)

Comment 8

[Wil Clouser [:clouserw]]

Bumping to 5.2 since wenzel is afk and this is a low priority bug

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 399523 [details] [diff] [review]
Patch, rev. 1

I know this is hard and hardly reproducible, so I suggest to r+ this if it still works and comment 6 makes sense.

Comment 11

[Wil Clouser [:clouserw]]

Comment on attachment 399523 [details] [diff] [review]
Patch, rev. 1

this doesn't break it for me, but I can't reproduce anyway.

Comment 12

[DS]

I can reproduce it without a problem.  Is it posted to somewhere public yet?

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> I can reproduce it without a problem.  Is it posted to somewhere public yet?

Not yet; in order to see it:

A) It would have to be checked in to SVN (which is picked up by http://preview.addons.mozilla.org automatically, every 15 minutes or so)
B) Bug 520850 would have to be fixed so that you could see it

Comment 14

[Fred Wenzel [:wenzel]]

I committed this to r52992.

DS: If you want to try it out, please wait about half an hour, then look at http://preview.addons.mozilla.org/ . Thanks!

Comment 15

[DS]

Attachment: View of the issue

Still seeing the same issue.

1)Clear cache just in case.
2)Force a new load using F5
3)Image is the result when in safe mode but also had the same result in regular mode

Comment 16

[Fred Wenzel [:wenzel]]

Did you type this text into the search box while the page was loading or how did the text get in there? If I type anything while the page is still loading, the label does not show up for me.

Comment 17

[DS]

I go to the front page and type in toolbars. ("Search for Add-ons" disappears)
Press enter on the keyboard.
When the first results page appears the result is the above image.

Comment 18

[Fred Wenzel [:wenzel]]

Ah, thank you. That is a different bug than comment 0, but we need to fix it as well.

Comment 19

[DS]

You might want to reopen this then.


https://bugzilla.mozilla.org/show_bug.cgi?id=517687

Comment 20

[Fred Wenzel [:wenzel]]

Thanks, I did.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Arch, is this now fixed for you on preview?  Thanks!