477000 - Remove installer code that adds unused registry key values

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

At the very least no longer add
Mozilla\<App Name>\<version> (<locale>)\Main\Program Folder Path
which is not used and is currently set with an incorrect path

Comment 1

[Robert Strong (they/them - no direct email)]

Also, Uninstall Log Folder

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Hey Jim, we don't use these two registry key values for anything and the one for 'Program Folder Path' is being incorrectly anyways... I'd like to get rid of them. Thanks

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/48e371648b83

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 360872 [details] [diff] [review]
patch rev1

Drivers, I'd like to get this for Firefox 3.1. This patch removes code that sets a couple of registry keys we don't use and one of the keys is written incorrectly.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 360872 [details] [diff] [review]
patch rev1

a191=beltzner

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1cb1be9526dd

Comment 7

[Robert Strong (they/them - no direct email)]

To verify this run the installer and check that the following registry keys don't exist where
${BrandFullNameInternal} = Minefield or Shiretoko
${AppVersion} = the version of the app e.g. 3.1b3pre or 3.2a1pre
${AB_CD} = the locale e.g. en-US

Path = Software\Mozilla\${BrandFullNameInternal}\${AppVersion} (${AB_CD})\Main"
Value name = "Program Folder Path"
 
Path = "Software\Mozilla\${BrandFullNameInternal}\${AppVersion} (${AB_CD})\Uninstall"
Value name = "Uninstall Log Folder"