477052 - Make some nanojit classes initialize their members

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

We go through the silliness of allocating our nanojit objects with an avmplus::GC, but the only reason for that is that LirBuffer's constructor (and maybe others) doesn't initialize its members.  All the GC does is zero them.

Low priority but I find this embarrassing.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Second this, IIRC Adobe wanted it to be optional so we'd have to #ifdef it.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: v1

The "#ifndef __MMgc__" here is because of comment 1.  I didn't bother in the case of LirBuffer or Fragmento, as I think they are long-lived and so the performance of the constructor doesn't matter.

Comment 3

[Edwin Smith]

Comment on attachment 361564 [details] [diff] [review]
v1

you're right that it's both embarrasing and low priority.  in terms of code size there are plenty other places we can reduce before size of initializers really matters.  (cough) macros.  no #ifdef necessary.

Comment 4

[Jason Orendorff [:jorendorff]]

Pushed to the Tracemonkey branch.

http://hg.mozilla.org/tracemonkey/rev/780189ed095c

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/780189ed095c

Comment 6

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9709d42e3068