We go through the silliness of allocating our nanojit objects with an avmplus::GC, but the only reason for that is that LirBuffer's constructor (and maybe others) doesn't initialize its members. All the GC does is zero them. Low priority but I find this embarrassing.
Second this, IIRC Adobe wanted it to be optional so we'd have to #ifdef it.
Created attachment 361564 [details] [diff] [review] v1 The "#ifndef __MMgc__" here is because of comment 1. I didn't bother in the case of LirBuffer or Fragmento, as I think they are long-lived and so the performance of the constructor doesn't matter.
Comment on attachment 361564 [details] [diff] [review] v1 you're right that it's both embarrasing and low priority. in terms of code size there are plenty other places we can reduce before size of initializers really matters. (cough) macros. no #ifdef necessary.
Pushed to the Tracemonkey branch. http://hg.mozilla.org/tracemonkey/rev/780189ed095c
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.