nsPluginHostImpl leaks when running mochitest in the "console" session as opposed to an RDP one

RESOLVED INCOMPLETE

Status

()

Core
Plug-ins
RESOLVED INCOMPLETE
9 years ago
5 years ago

People

(Reporter: bhearsum, Unassigned)

Tracking

Trunk
x86
Windows Server 2003
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

9 years ago
I'm doing some work on our win32 build machines right now that may result in us running tests from the "console" session rather than an RDP one. During initial tests I've seen a consistent leak in nsPluginHostImpl happening on mozilla-1.9.1, mozilla-central, and tracemonkey unit tests. Here's the details:
== BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          17      188 1555149935        4 (53352.96 +/-     0.00) 346121445        3 (20019.70 +/-     0.00)
 667 nsLocalFile                                    88       88    33989        1 (  238.51 +/-    43.25)   123213        1 (  369.50 +/-    84.46)
 760 nsPluginHostImpl                               88       88        1        1 (    1.00 +/-     0.00)     4354        1 (   11.77 +/-     3.71)
 943 nsStringBuffer                                  8        8  7347552        1 (25130.85 +/-  4469.28) 13495209        1 (27574.96 +/-  3435.31)
1033 nsVoidArray                                     4        4 67579154        1 (10810.39 +/-  2643.72)        0        0 (    0.00 +/-     0.00)

nsTraceRefcntImpl::DumpStatistics: 1158 entries
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 188 bytes during test execution
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsLocalFile with size 88 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsPluginHostImpl with size 88 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsStringBuffer with size 8 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsVoidArray with size 4 bytes

On 1.9.1 there's an additional leak of nsWeakReference:
1034 nsWeakReference                                12       12    64516        1 (  799.24 +/-   272.73)   419883        1 ( 1944.96 +/-   831.27)

I can reproduce this 100% of the time so I'm happy to help track it down.
Summary: nsPluginHostImpl leaks when running in the "console" session as opposed to an RDP one → nsPluginHostImpl leaks when running mochitest in the "console" session as opposed to an RDP one
(Reporter)

Comment 1

9 years ago
Any chance someone can look at this? When bug 428123 gets rolled out this bug is going to have to be fixed, or we're going to have to adjust the mochitest leak threshold.
(Reporter)

Comment 2

9 years ago
Created attachment 361593 [details]
balance tree from a leaking run
(Reporter)

Updated

9 years ago
Attachment #361593 - Attachment description: balance tree run a leaking run → balance tree from a leaking run
(Reporter)

Comment 3

9 years ago
Created attachment 361816 [details]
proper balance tree
(Reporter)

Comment 4

9 years ago
Created attachment 361833 [details]
balance tree with proper symbols
Attachment #361593 - Attachment is obsolete: true
Attachment #361816 - Attachment is obsolete: true
(Reporter)

Comment 5

9 years ago
Created attachment 362221 [details]
latest balance tree

I don't think the previous balance tree is quite right either, this is my most recent one, with --disable-optimize and --disable-debug. Generated after leaking on test_HTMLDocument07.html.
Attachment #361816 - Attachment is patch: false
(Reporter)

Comment 6

9 years ago
Created attachment 362305 [details]
balance tree, again

bent suggested trying to find this leak without mochitest. This is the balance tree I got after doing so.
Attachment #361833 - Attachment is obsolete: true
Attachment #362221 - Attachment is obsolete: true
(Reporter)

Comment 7

9 years ago
Interestingly, I can't reproduce this on mozilla-central. I had a look over the plugin related checkins since the start of the year and a few popped out to me:
bug 476409 - http://hg.mozilla.org/mozilla-central/rev/a7853b4dbd34
bug 474022 - http://hg.mozilla.org/mozilla-central/rev/011d2208412c and http://hg.mozilla.org/mozilla-central/rev/bf1556e3ed4b
bug 474866 - http://hg.mozilla.org/mozilla-central/rev/0932e7c4d976 and http://hg.mozilla.org/mozilla-central/rev/abd5a41c0b70

The last two look particularly suspicious given that we sometimes leak an nsWeakReference. But then again, they look like they're on 1.9.1 already, so probably not!
(Reporter)

Comment 8

5 years ago
I don't think we care about this anymore.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.