Closed Bug 477150 Opened 11 years ago Closed 11 years ago

Improve Places history window context menu


(SeaMonkey :: UI Design, defect)

Not set


(Not tracked)



(Reporter: neil, Assigned: neil)




(1 file, 1 obsolete file)

In its current state it's not quite as useful as the old one used to be.
Attached patch Initial patch (obsolete) — Splinter Review
* Made the open in window command work with multiple history entries
* Reused the code to work with opening in tabs and removed tab-specific code
* Removed checks for metadata properties that don't exist in history
* Fixed the backend for adding multiple bookmarks and added a menuitem
* Added Select All context menuitem
* Stopped marking pages as typed because old history window didn't do that
However, I stopped short of adding the delete all from host/domain menuitems to the context menu as you requested in bug 473007 because the context menu is also used in the sidebar but the sidebar doesn't get any command updates, so making it work would probably get very ugly. Even synchronising the labels is ugly.
Assignee: nobody → neil
Attachment #360818 - Flags: review?(iann_bugzilla)
bah, Error: undefined entity
Source File: chrome://communicator/content/history/placesOverlay.xul
Line: 105, Column: 5
Source Code:
    <menuitem id="addBookmarkContextItem"
Comment on attachment 360818 [details] [diff] [review]
Initial patch

Seem to be missing some locale changes...
Attachment #360818 - Flags: review?(iann_bugzilla) → review-
Attachment #360818 - Attachment is obsolete: true
Attachment #361243 - Flags: review?(iann_bugzilla)
Comment on attachment 361243 [details] [diff] [review]
Including locale changes

We seem to be a bit inconsistent between context windows history vs bookmarks. In history we have "Open Link in New Window" whereas bookmarks has "Open in New Window". I prefer the latter as then we do not have to worry about singular or plural, the former means we should be adding (s) or doing something similar to what is done for This/These in the "Bookmark This Link" context item.
r=me with this addressed.

Again not this bug but shouldn't shift click in the history sidebar do something similar to shift click on a link within a web page?
Attachment #361243 - Flags: review?(iann_bugzilla) → review+
(In reply to comment #5)
> (From update of attachment 361243 [details] [diff] [review])
> Again not this bug but shouldn't shift click in the history sidebar do
> something similar to shift click on a link within a web page?
Gives this message in the error console:
Error: saveURL is not defined
Source File: chrome://communicator/content/utilityOverlay.js
Line: 1157
Pushed changeset fecd76c1f3fc to comm-central.
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.