477190 - Miscellaneous issues in plural messages

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Anas Husseini [:linostar]]

First issue - messages that need to be in plural-form:

<em>%s</em> Weekly Downloads
<em>%s</em> Total Downloads
<em>%s</em> Active Daily Users
%s days (msgid "editors_x_days")
%s hours (msgid "editors_x_hours")
%s minutes (msgid "editors_x_minutes")


Second issue - plural messages that need to be fixed:

That applies on the newly added "Addon Types" messages. See bug 476833 and bug 476836 for more details.

Comment 1

[Wil Clouser [:clouserw]]

Can you explain the second issue in the context of AMO strings?

Comment 2

[Anas Husseini [:linostar]]

(In reply to comment #1)
> Can you explain the second issue in the context of AMO strings?

When the plural message doesn't contain a reference to the numeric variable (e.g. '%s' or '%1$s'), that means that the number will be externally added to the message. But if '%s' (or its equivalent) is included within the message, the localizer has control on it, either keep it or delete it. That is the case of Arabic language for numbers 0, 1 and 2, because if the number appears with the message, it will become something like "2 two-Extensions", since the nouns in Arabic implicitly express their quantities if it is for 0, 1 or 2 items.

As conclusion, messages like: (msgstr[0] "Extension" & msgstr[1] "Extensions") should be replaced by something like: (msgstr[0] "%s Extension"  &  msgstr[1] "%s Extensions"). That rule should be applied everywhere whatever was the component.

Thanks

Comment 3

[Wil Clouser [:clouserw]]

Ah, I see.  Are we concatenating a number to that string anywhere?  I think it's just used independently.  For example, the "Extensions" link in the menu  (in which case, storing it as a plural form may be wrong...)

Comment 4

[Anas Husseini [:linostar]]

Well, I assumed these Add-on Types are displayed with numbers, so that's why they are in plural-form. If it's not the case, the second issue is dissolved, and plural-form is not needed for these messages.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> Well, I assumed these Add-on Types are displayed with numbers, so that's why
> they are in plural-form. If it's not the case, the second issue is dissolved,
> and plural-form is not needed for these messages.

You're right - I messed this up.  However, I've fixed in in SVN and emailed the dev-l10n-web list so we should be good.  #1 is still a valid complaint.

Comment 6

[fcp]

(In reply to comment #0)
> First issue - messages that need to be in plural-form:

Another example is the link to the reviews page from the Reviews section of the add-on details page which reads “See all 1 reviews of this add-on.”  See e.g.
https://preview.addons.mozilla.org/en-US/firefox/addon/1594#reviews

This applies both to AMO 5.0.7 and preview.addons.mozilla.org.

Comment 7

[Wil Clouser [:clouserw]]

r49707