47720 - We should use mozilla/uriloader to fetch import/includes

Status: VERIFIED FIXED

(Core :: XSLT, defect, P3)

Description

[Jus]

It seems to me that transformiix can only get files using file: protocol, as the
source/net library has cases for only this.
Not only should we support the other types, we are bypassing the normal caching
routines.
We should probably be using a mozilla uriloader or the like to provide the
stream for the parser, as apposed to doing this ourselves.

Comment 1

[Keith Visco]

Yes, Transformiix *standalone* Only supports the file protocol. This is not a 
bug, and is noted in the documentation. As far as integration with Mozilla is 
concerned, we should definately be using Mozilla's URI resolving capabilities. I 
know Peter is looking into this, and you should definately get in touch with him 
on this.

Comment 2

[Peter Van der Beken]

Yes, i am working on this and have most of the implementation. Some bugs to fix 
and a little cleanup to do and i'll check it in.

Comment 3

[Jus]

Sweet.
Ill await the changes with glee. If you need a hand to test/debug let me know.

Comment 4

[Jus]

Peter,
The work your doing on this, does it also involve modifications to DOM Wrapper 
classes? I see in your comments to Document::Document() that you commented out 
the constructor for the mozilla XML document (Since it doesnt link). This is 
used for import/include stylesheets, and currently hard crashs on include.xml 
because nsDocument is unassigned. Ive tried to quickly rectify this, but can 
not find an appropriate factory to build nsIXMLDocuments (or any other type of 
useful document).
If your not covering this, then well just chalk it up as another thing to worry 
about during the inteface redesign.

Comment 5

[Peter Van der Beken]

Jus,
I've got that implemented too (going through nsIDOMImplementation). I have a ton 
of patches in my local tree that i need to get in. I'll be doing that in the 
following weeks (2 weeks of vacation coming up and i'll be spending them 
completely on Mozilla/Transformiix). Thanks for your help! Be sure to ask before 
you start working on something, it'd be stupid for both of us to implement the 
same things :-).

Comment 6

[Peter Van der Beken]

Taking over as this is an integration issue.

Comment 7

[Axel Hecht]

fixed for mozilla module by peterv, checked in by me

Axel

Comment 8

[Axel Hecht]

We haven't been verifying bugs for quite a while :-(