Closed
Bug 477225
Opened 15 years ago
Closed 15 years ago
[MIR] PPC64 compile problem under Xcode
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: lhansen, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
383 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
The compiler complains about a cast in the MIR code. Here's a simple fix for that; more likely the problem is that the MIR code should not be compiled at all for PPC64 now that we have LIR support.
Attachment #360896 -
Flags: review?(edwsmith)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 360896 [details] [diff] [review] Patch Correct, AVMPLUS_MIR should not be turning itself on with PPC && 64BIT. the cast looks fine but MIR has no chance of working as-is on PPC64.
Attachment #360896 -
Flags: review?(edwsmith) → review+
|
Reporter | |
Comment 2•15 years ago
|
||
I'll push this fix then, just for the sake of argument, since it's blocking the xcode project files. Do you want to look into the necessary mojo to disable MIR for this configuration?
|
|
Reporter | |
Comment 3•15 years ago
|
||
Turns out that the problem is in SparcAssembler.cpp, which includes CodegenMIR.h without checking whether MIR is enabled (actually the entire file depends on MIR being enabled but is not protected). Adding the obvious #ifdef fixes this.
Attachment #360902 -
Flags: review?(lhansen)
|
|
Reporter | |
Comment 4•15 years ago
|
||
redux changeset: 1410:bd3008173b76
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•15 years ago
|
Attachment #360902 -
Attachment is obsolete: true
Attachment #360902 -
Flags: review?(lhansen)
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•