477262 - viewportVisibleRect can return null if the viewingRect has size 0

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

this is causing trouble if we get spurious 0/0 resize events early in startup. I propose we fix wsRect.intersect to return [0,0,0,0] for [0,0,0,0].intersect(0,0,10,10), rather than null.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Though I suppose it doesn't make too much sense to return an no-width/height rect when two rects are adjacent but don't actually interesect. We could special case 0-width/height rects I suppose, but perhaps we should just have the viewportVisibleRect deal with non-intersecting rects.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: make viewportVisibleRect deal with a null intersect result

possible fix if we make viewportVisibleRect deal with the null result from intersect

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 360970 [details] [diff] [review]
make viewportVisibleRect deal with a null intersect result

yeah, let's just do this

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/f021711f4e8d

Comment 5

[Dão Gottwald [:dao]]

bugspam