Closed Bug 477326 Opened 11 years ago Closed 11 years ago

valgrind: uninitialized nsXULPopupManager::mCachedMousePoint running test_closemenu_attribute.xul

Categories

(Core :: XUL, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: enndeakin)

Details

Attachments

(2 files)

Attached file valgrind warnings
When I run the mochitest toolkit/content/tests/widgets/test_closemenu_attribute.xul under valgrind on Linux, I see a series of warnings about conditional jumps depending on uninitialized values.  Note that the stacks for these warnings can be a decent distance away from the cause of the problem, since valgrind only warns when uninitialized data is used for a branch or a system call.

The first of the warnings is probably the first to look into, but the best technique is often to force other (earlier) branches based on the pieces of data that might be suspicious, and see which ones valgrind warns about.  (e.g., if ... == nsnull ) { printf("hi") })
My initial suspicion about where the uninitialized data came from turned out to be correct (based on adding a printf of the data itself, actually).  The problem here is that in nsXULPopupManager::FirePopupShowingEvent, mCachedMousePoint is uninitialized.
Summary: valgrind warning about uninitialized values running test_closemenu_attribute.xul → valgrind: uninitialized nsXULPopupManager::mCachedMousePoint running test_closemenu_attribute.xul
(In reply to comment #1)
> mCachedMousePoint is uninitialized.

I should say, is uninitialized or was initialized from something that was in turn uninitialized (etc., ad. inf.).
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #362719 - Flags: superreview?(roc)
Attachment #362719 - Flags: review?(roc)
Attachment #362719 - Flags: superreview?(roc)
Attachment #362719 - Flags: superreview+
Attachment #362719 - Flags: review?(roc)
Attachment #362719 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Component: XP Toolkit/Widgets: Menus → XUL
You need to log in before you can comment on or make changes to this bug.