3 broken queries on stats pages when not logged in

VERIFIED FIXED in 5.0.2

Status

addons.mozilla.org Graveyard
Statistics
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

unspecified
5.0.2

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 361018 [details] [diff] [review]
fix broken queries

When you aren't logged in and you visit /en-US/firefox/statistics/1865 you get 3 SQL queries that fail due to syntax.  This is because we're assuming the user is logged in when they might not be.

This patch fixes the problem.  The only reason I'm r?ing it is I wanted someone to double check that my returning false in checkOwnership() isn't going to break anything else.  I'm pretty sure it will eventually return false anyway but want to make sure.
Attachment #361018 - Flags: review?(lorchard)
Starting to look at this, I think I already have some fixes for these in my patch in bug 473244, since the warnings were blocking me from getting things working.  Might need to see which work better and resolve any conflicts
Comment on attachment 361018 [details] [diff] [review]
fix broken queries

Can't get this patch to apply after my commit for bug 473244.  Also looks like that included a fix for the same thing in controllers/components/amo.php
Attachment #361018 - Flags: review?(lorchard) → review-
(Assignee)

Comment 3

9 years ago
I agree, this is fixed.  thanks
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Was the failure ever visible to the end-user, or was it just debug-spew?

Thanks.
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> Was the failure ever visible to the end-user, or was it just debug-spew?
> 
> Thanks.

Only visible on development sites.
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.