477350 - 3 broken queries on stats pages when not logged in

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: fix broken queries

When you aren't logged in and you visit /en-US/firefox/statistics/1865 you get 3 SQL queries that fail due to syntax.  This is because we're assuming the user is logged in when they might not be.

This patch fixes the problem.  The only reason I'm r?ing it is I wanted someone to double check that my returning false in checkOwnership() isn't going to break anything else.  I'm pretty sure it will eventually return false anyway but want to make sure.

Comment 1

[Les Orchard [:lorchard]]

Starting to look at this, I think I already have some fixes for these in my patch in bug 473244, since the warnings were blocking me from getting things working.  Might need to see which work better and resolve any conflicts

Comment 2

[Les Orchard [:lorchard]]

Comment on attachment 361018 [details] [diff] [review]
fix broken queries

Can't get this patch to apply after my commit for bug 473244.  Also looks like that included a fix for the same thing in controllers/components/amo.php

Comment 3

[Wil Clouser [:clouserw]]

I agree, this is fixed.  thanks

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Was the failure ever visible to the end-user, or was it just debug-spew?

Thanks.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> Was the failure ever visible to the end-user, or was it just debug-spew?
> 
> Thanks.

Only visible on development sites.