Closed Bug 4774 Opened 25 years ago Closed 25 years ago

Style buttons should reflect current selection.

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sujay, Assigned: sfraser_bugs)

References

Details

(Whiteboard: [PDT-] EB Fix date: 2/24) 

using 4/7 build of apprunner on Windows

1) launch apprunner -editor
2) highlight some text.
3) click on Bold/Italic/underline button

here are the issues:

  a) for italic and underline, the highlighting disappears after clicking
     on those style buttons
  b) for bold, still can't notice that the text looks bold thru the highlight.
     I do see the font size increase thru the highlight.
     (I might need to recheck this in the 4/8 build. fix might have not made it.
  c) after clicking any of the style buttons(bold, italic, underline). To
     change it back to the original text, it doesn't work. Buttons don't
     revert to original text.

I was gonna file these as 3 separate bugs, but decided to lump everything
into one bug.
Status: NEW → ASSIGNED
Is this Linux or Win32 or ALL platforms?
OS: Linux → All
this is all platforms actually....changing to all...
should have been 3 separate bugs.  It's harder to track these issues now.  In
the future, more bugs is better (my personal opinion, I know some people
disagree.)
Hardware: Other → All
platform = all
Assignee: buster → sfraser
Status: ASSIGNED → NEW
the first 2 issues are fixed.
the third issue has to do with the way the XUL is hooked up to the editor.  In
particular, we can't find out what style the selection has until we get the
out-param issue resolved.  Simon is looking into this I think, so I'm
reassigning this bug to him.
Status: NEW → ASSIGNED
Not sure what's going on here, but I'll take a look.
Target Milestone: M6
M6.
I fixed the JS out params problem by converting those out params to strings,
in the appcore interface. The appcore now tries to remove tags "U", "B", and "I"
when you hit the remove styles button. It seems that we should remove all styles,
not just those, but I'm not sure how we'd achieve that.
Summary: style change issues. → Style buttons should reflect current selection.
Target Milestone: M6 → M7
M7, adjusted summary.
Blocks: 5713
No longer blocks: 5713
Target Milestone: M7 → M8
Target Milestone: M8 → M9
M9
*** Bug 10936 has been marked as a duplicate of this bug. ***
Target Milestone: M9 → M10
This is almost all done, apart from the list buttons (for which bug 10661
exists), and the alignment, font and font size popups. They can wait until M10.
Target Milestone: M10 → M11
M11 for the parts that are left.
Target Milestone: M11 → M12
moved to M12, the basic functionality is in place and the details can wait a
bit.
Summary: Style buttons should reflect current selection. → [BETA]Style buttons should reflect current selection.
Whiteboard: [BETA general cleanup]
Target Milestone: M12 → M14
moving to M14, pre-beta celanup
Whiteboard: [BETA general cleanup] → [PRE-BETA]
setting keyword
Keywords: beta1
Summary: [BETA]Style buttons should reflect current selection. → Style buttons should reflect current selection.
Whiteboard: [PRE-BETA]
This would be nice to have for beta 1, but not a stop ship. PDT-
Whiteboard: PDT-
Target Milestone: M14 → M15
adding EB in status summary...Ender Blocker
Whiteboard: PDT- → PDT- EB
This should get fixed by a checkin in nsTitledButtonFrame that hyatt will make 
later today.
Whiteboard: PDT- EB → PDT- EB Fix date: 2/24
Per today's PDT with bijals, definitely PDT-.
Whiteboard: PDT- EB Fix date: 2/24 → [PDT-] EB Fix date: 2/24
This should work now, after a checkin by hyatt.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
verified in 2/28 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.