477504 - bc_borderoffset2.html reftest failure on the mac

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Bernd]

the reftest fails on tinderbox, I don't have a mac so I am disabling the test for now.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: output from tinderbox

Comment 2

[Bernd]

http://hg.mozilla.org/mozilla-central/rev/2094c3c88666

Comment 3

[Jonathan Watt [:jwatt]]

The reason this is happening is because generally border lines are snapped to device pixels implicitly because they are drawn using nsRenderingContext::DrawLine/DrawRect/FillRect which all snap. However, in one case in nsCSSRendering.cpp's DrawSolidBorderSegment we use nsRenderingContext::FillPolygon() to bevel the edges, and that function does not do snapping.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

I've been porting nsRenderingContext code to Moz2D so the code I mentioned in the previous comment is no longer using nsRenderingContext. This patch changes the new Moz2D code to use the variant of NSRectToRect that takes a DrawTarget so that it can snap to the DrawTarget's device pixels.

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8507830 [details] [diff] [review]
patch

Looks good.  (don't forget to add a commit message)

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 8507830 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/171e352854e7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/171e352854e7