the reftest fails on tinderbox, I don't have a mac so I am disabling the test for now.
The reason this is happening is because generally border lines are snapped to device pixels implicitly because they are drawn using nsRenderingContext::DrawLine/DrawRect/FillRect which all snap. However, in one case in nsCSSRendering.cpp's DrawSolidBorderSegment we use nsRenderingContext::FillPolygon() to bevel the edges, and that function does not do snapping.
Assignee: bernd_mozilla → jwatt
Created attachment 8507829 [details] [diff] [review] patch I've been porting nsRenderingContext code to Moz2D so the code I mentioned in the previous comment is no longer using nsRenderingContext. This patch changes the new Moz2D code to use the variant of NSRectToRect that takes a DrawTarget so that it can snap to the DrawTarget's device pixels.
Created attachment 8507830 [details] [diff] [review] patch
Comment on attachment 8507830 [details] [diff] [review] patch Looks good. (don't forget to add a commit message)
Attachment #8507830 - Flags: review?(mats) → review+
Comment on attachment 8507830 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/171e352854e7
Attachment #8507830 - Flags: checkin+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.