bc_borderoffset2.html reftest failure on the mac

RESOLVED FIXED in mozilla36

Status

()

Core
Layout: Tables
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: Bernd, Assigned: jwatt)

Tracking

Trunk
mozilla36
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
the reftest fails on tinderbox, I don't have a mac so I am disabling the test for now.
Created attachment 361166 [details]
output from tinderbox
(Assignee)

Comment 3

4 years ago
The reason this is happening is because generally border lines are snapped to device pixels implicitly because they are drawn using nsRenderingContext::DrawLine/DrawRect/FillRect which all snap. However, in one case in nsCSSRendering.cpp's DrawSolidBorderSegment we use nsRenderingContext::FillPolygon() to bevel the edges, and that function does not do snapping.
Assignee: bernd_mozilla → jwatt
(Assignee)

Comment 4

4 years ago
Created attachment 8507829 [details] [diff] [review]
patch

I've been porting nsRenderingContext code to Moz2D so the code I mentioned in the previous comment is no longer using nsRenderingContext. This patch changes the new Moz2D code to use the variant of NSRectToRect that takes a DrawTarget so that it can snap to the DrawTarget's device pixels.
Attachment #8507829 - Flags: review?(mats)
(Assignee)

Comment 5

4 years ago
Created attachment 8507830 [details] [diff] [review]
patch
Attachment #8507829 - Attachment is obsolete: true
Attachment #8507829 - Flags: review?(mats)
Attachment #8507830 - Flags: review?(mats)
Comment on attachment 8507830 [details] [diff] [review]
patch

Looks good.  (don't forget to add a commit message)
Attachment #8507830 - Flags: review?(mats) → review+
https://hg.mozilla.org/mozilla-central/rev/171e352854e7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.