Closed Bug 477522 Opened 11 years ago Closed 11 years ago

remove nsStyleContext::DumpRegressionData and code it uses

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This patch removes nsStyleContext::DumpRegressionData, because;
 * it's a good bit of code that adds maintenance cost when we remember to maintain it, but is also quite a bit out of data
 * we have much better ways of doing regression testing now

(If we ever wanted to rewrite it, it should be a simple loop over the data in nsCSSPropList and using the code in nsComputedDOMStyle.)
Attachment #361182 - Flags: superreview?(bzbarsky)
Attachment #361182 - Flags: review?(bzbarsky)
Attachment #361182 - Flags: superreview?(bzbarsky)
Attachment #361182 - Flags: superreview+
Attachment #361182 - Flags: review?(bzbarsky)
Attachment #361182 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/66db3742d013
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.