Closed
Bug 477530
Opened 15 years ago
Closed 15 years ago
SetBaseValueString on nsSVGViewBox and nsSVGPreserveAspectRatio do not notify element of change
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
DUPLICATE
of bug 435525
People
(Reporter: craig.topper, Assigned: craig.topper)
References
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
SetBaseValueString on nsSVGViewBox and nsSVGPreserveAspectRatio don't call DidChangeViewBox or DidChangePreserveAspectRatio so the parent element isn't notified of the change. At the very least this prevents redrawing of <svg> elements if a script calls SetAttribute with one of these attributes.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #361212 -
Flags: review?(longsonr)
|
||
Updated•15 years ago
|
Attachment #361212 -
Flags: review?(longsonr) → review+
|
|
||
Comment 2•15 years ago
|
||
This probably should just have been part of bug 435525. It would be easier if you just added this patch to that bug if you don't yet have check-in access.
|
|
Assignee | |
Comment 3•15 years ago
|
||
I didn't realize the scope of the issue when I filed this bug. What's the best way to merge these and communicate it?
|
|
||
Comment 4•15 years ago
|
||
If I were you I would update the patch in the other bug with these lines. Then mark this bug as a duplicate of that one.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•15 years ago
|
||
Oops didn't mean to mark this as fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•15 years ago
|
||
Marking as duplicate of 435525 and integrating patch with the one for that bug to simplify things per comment #4.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•