477591 - missing semi-colon in DownloadUtils.jsm

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Attachment: downloadutils.diff

from Error Console

Error: missing ; before statement
Source File: file:///Users/rob/Applications/Shiretoko.app/Contents/MacOS/modules/DownloadUtils.jsm
Line: 76
Source Code:
let kStrings = {

Comment 1

[Ed Lee :Mardak]

How are you running into that error? Strict mode? Does it prevent actual functionality of the download utils/download manager/statusbar?

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/4f9cc1d2e234

Comment 3

[Rob Campbell [:rc] (:robcee)]

(In reply to comment #1)
> How are you running into that error? Strict mode? Does it prevent actual
> functionality of the download utils/download manager/statusbar?

I ran into that this morning, possibly as a side-effect of bug 467747. I had a bunch of "missing ;" errors and this one happened to have one in it. Just luck, I guess!

(and yes, the other bug prevents functionality of download manager, add-ons and places)

Comment 4

[Rob Campbell [:rc] (:robcee)]

ps thanks for the quick push!

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361264 [details] [diff] [review]
downloadutils.diff

a191=beltzner

Comment 6

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/5340be8e4273

Comment 7

[Rob Campbell [:rc] (:robcee)]

clearing some old flags.