477597 - [Fennec] xpcshell unittest: test_update/unit/test_0030_general.js fails to do a mar download with various encryption types

Status: VERIFIED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

In testing the xpcshell unit tests, I ran into a case where all the tests fail:
test_update/unit/test_0030_general.js

This has 11 different tests which test a mar download using different encryptions methods (SHA1, MD5, etc..)

We need to assert if this test is valid for Fennec.

To run this test by hand here is a cli (adjust the paths):
/home/mozilla/mozilla/mobile_debug/xulrunner/dist/bin/xpcshell -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/head.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/head_update.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/test_0030_general.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/tail.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell-simple/test_update/unit/tail_update.js -f /home/mozilla/mozilla/mobile_debug/xulrunner/_tests/xpcshell/execute_test.js

In addition here is some documentation on how to run xpcshell in fennec:
https://wiki.mozilla.org/Mobile/Fennec_Xpcshell

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

moving to toolkit:application update as this is specific to a test, not fennec.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

In addition, when using Ted's new runxpcshelltests.py for fennec, this is the only test that causes it to hang.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

oops, spoke too soon, it appears the be the test_0040_general.js test, not this one

Comment 4

[Robert Strong (they/them - no direct email)]

Comment #2 From  Robert Strong [:rs] (do not email)   2009-04-17 15:41:53 PDT   (-) [reply] -------

Could you check if commenting out the following lines makes the test pass?
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2683

var brandStrings = sbs.createBundle(URI_BRAND_PROPERTIES);
var brandShortName = brandStrings.GetStringFromName("brandShortName");
this._update.statusText = updateStrings.formatStringFromName("verificationError",
                                                             [brandShortName], 1);

Comment 5

[Robert Strong (they/them - no direct email)]

Filed bug 488928 which *might* also fix this bug

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

commenting out the 3 linesof code in nsUpdateService.js.in do not appear to fix the case.  Although I am getting the test hanging and not returning anything.

Comment 7

[Robert Strong (they/them - no direct email)]

Joel, per your bug 477594 comment #23 - does this test now pass?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

yes, this test passes and I have confirmed multiple times on both fennec-linux and fennec-maemo

Comment 9

[Robert Strong (they/them - no direct email)]

This was most likely fixed by bug 493805 or one of the other test cleanup bugs
I landed... resolving -> wfm

Comment 10

[Robert Strong (they/them - no direct email)]

test_0030_general.js failed according to the maemo xpcshell test log.
http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1245986821.1245992256.2551.gz&fulltext=1

TEST-UNEXPECTED-FAIL | /media/mmc1/release/xpcshell/tests/test_update/unit/test_0030_general.js | test failed (with xpcshell return code: -11), see following log:
</font>  >>>>>>>
  TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-INFO | (xpcshell/head.js) | test 2 pending
*** AUS:SVC UpdateService:canUpdate - testing /media/mmc1/release/fennec/xulrunner/update.test
*** AUS:SVC General:getUpdatesDir - update directory /media/mmc1/release/fennec/xulrunner/updates/0 doesn't exist, creating...
*** AUS:SVC UpdateService:canUpdate - testing /media/mmc1/release/fennec/xulrunner/updates/0/update.test
*** AUS:SVC UpdateService:canUpdate - able to update
*** AUS:SVC General:readStringFromFile - file doesn't exist: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC General:readStatusFile - status: null, path: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC UpdateService:_postUpdateProcessing - no status, no update
*** AUS:SVC UpdateManager:_loadXMLFileIntoArray: XML file does not exist
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | running event loop
Testing: run_test_pt1 - mar download with a valid MD5 hash
*** AUS:SVC Checker:getUpdateURL - update URL: http://localhost:4444/update.xml?force=1
*** AUS:SVC Checker:checkForUpdates - sending request to: http://localhost:4444/update.xml?force=1
*** AUS:SVC Checker:onLoad - request completed downloading document
*** AUS:SVC Checker:getUpdateURL - update URL: http://localhost:4444/update.xml?force=1
*** AUS:SVC Checker:onLoad - number of updates available: 1
onError: url = http://localhost:4444/update.xml?force=1, request.status = 400, update.statusText = null, updateCount = 1
TEST-PASS | /media/mmc1/release/xpcshell/tests/test_update/unit/test_0030_general.js | [check_test_helper_pt1_1 : 93] 1 == 1
*** AUS:SVC General:readStringFromFile - file doesn't exist: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC General:readStatusFile - status: null, path: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC UpdateManager:_loadXMLFileIntoArray: XML file does not exist
*** AUS:SVC UpdateManager:_loadXMLFileIntoArray: XML file does not exist
*** AUS:SVC Downloader:downloadUpdate - downloading from http://localhost:4444/data/empty.mar to /media/mmc1/release/fennec/xulrunner/updates/0/update.mar

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

this has been failing the last 2 times I tried this on my maemo device including a build from this weekend.  

TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-INFO | (xpcshell/head.js) | test 2 pending
*** AUS:SVC UpdateService:canUpdate - testing /media/mmc1/release/fennec/xulrunner/update.test
*** AUS:SVC General:getUpdatesDir - update directory /media/mmc1/release/fennec/xulrunner/updates/0 doesn't exist, creating...
*** AUS:SVC UpdateService:canUpdate - testing /media/mmc1/release/fennec/xulrunner/updates/0/update.test
*** AUS:SVC UpdateService:canUpdate - able to update
*** AUS:SVC General:readStringFromFile - file doesn't exist: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC General:readStatusFile - status: null, path: /media/mmc1/release/fennec/xulrunner/updates/0/update.status
*** AUS:SVC UpdateService:_postUpdateProcessing - no status, no update
*** AUS:SVC UpdateManager:_loadXMLFileIntoArray: XML file does not exist


This doesn't have a fail, but the summary that I see is this:
TEST-UNEXPECTED-FAIL | /media/mmc1/release/xpcshell/tests/test_update/unit/test_0030_general.js | test failed (with xpcshell return code: -4), see following log:

Comment 12

[Robert Strong (they/them - no direct email)]

Joel, could you point it at an external server like you did for WinMo to see if the http server is working? Thanks

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

the http server is working on maemo, but I will give this a try on a remote system just to double check.