477653 - sizemode=maximized causes multiple resize events

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

when using sizemode=maximized in our window define, we see multiple resize events on linux and windows mobile.

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.xul#55

However, when we use fixed sizes like 'width="720" height="420"', there is only resize event fired.

On linux:

without sizemode=maximized:
resize: 720x420

with sizemode=maximized:
resize: 1025x800
resize: 1025x800
resize: 720x420

This problem was uncovered when we switched from our browser window having a fixed size to just using the sizemode attribute in bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=476705

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: mobile-browser fix

This patch adds some logic to the resizeHandler to ignore any resize attempts that aren't at the final width - based on sizemode="maximized"

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

The patch does not stop the platform from sending the initializtion resizes. The patch merely ignores any resizes it can and does reduce the resize speed regressions to 1 effective resize.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 365212 [details] [diff] [review]
mobile-browser fix

I'm assuming you tested this on the n810 to make sure it worked as expected... My only concern is that there are platforms (WinCE?) where availWidth will not match window width even when "maximized"...

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)
> (From update of attachment 365212 [details] [diff] [review])
> I'm assuming you tested this on the n810 to make sure it worked as expected...
> My only concern is that there are platforms (WinCE?) where availWidth will not
> match window width even when "maximized"...

Yes, I did test on the n810 and screen.availWidth does match final window.innerWidth

I did not test on WinMo yet. Also, orientation might cause things to not match up either.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/be656c9463a9

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

filed bug 481243 to look into this on a platform level.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

What would be a good way to verify this?

Comment 8

[Aakash Desai [:aakashd]]

We can do an assertJS across winMo and Maemo devices via console with screen.availWidth and window.innerWidth equaling each other.

Mark, Brad, Gavin; what do you guys think?

Comment 9

[Dão Gottwald [:dao]]

bugspam