477693 - [RTL] Drop downs for folders on bookmarks toolbar are distorted for RTL locales

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Distortion when hovering a folder

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090209020514

Today I did a test with a RTL build of Firefox3.1b3pre and I have seen that the drop downs on the bookmarks toolbar are distorted. This happens for hovering over and opening a bookmarks folder. See the attached screenshots. It looks like that the images weren't flipped.

Alex, do we have a tracking bug for FF3.1 theming issues?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Distortion when selecting a folder

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Reference how it should look like

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>Alex, do we have a tracking bug for FF3.1 theming issues?

we are using whiteboard terms [polish-easy] or [polish-hard], as well as [polish-visual] or [polish-interactive].

Mike: this does look pretty broken, assuming it isn't much work to fix we might want to pick it up as a blocker.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Agree that this blocks; when did it regress?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regressed between the build from 0810602 and 08100902:
http://tinyurl.com/be9v3g

I highly suspect bug 438302 which operates on the text-shadow and touches the toolbar-button stack. Dao, what do you think?

Comment 6

[Dão Gottwald [:dao]]

Attachment: patch (checked-in)

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/319799933481
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3b09df245485

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sadly it is not fixed completely. The drop down looks fine but there is still a gap between the folder name and the drop down. See the screenshot.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Gap between folder name and drop down

Comment 10

[Dão Gottwald [:dao]]

Attachment: followup

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/045dec3ec57f
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/609d86674103

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fa; rv:1.9.2a1pre) Gecko/20090219 Minefield/3.2a1pre ID:20090219020624

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fa; rv:1.9.1b3pre) Gecko/20090219 Shiretoko/3.1b3pre ID:20090219020454

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.