[RTL] Drop downs for folders on bookmarks toolbar are distorted for RTL locales

VERIFIED FIXED in Firefox 3.6a1

Status

()

defect
P2
normal
VERIFIED FIXED
11 years ago
6 years ago

People

(Reporter: whimboo, Assigned: dao)

Tracking

({regression, rtl, verified1.9.1})

3.5 Branch
Firefox 3.6a1
All
macOS
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [polish-easy][polish-visual][polish-p2])

Attachments

(6 attachments)

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre Ubiquity/0.1.5 ID:20090209020514

Today I did a test with a RTL build of Firefox3.1b3pre and I have seen that the drop downs on the bookmarks toolbar are distorted. This happens for hovering over and opening a bookmarks folder. See the attached screenshots. It looks like that the images weren't flipped.

Alex, do we have a tracking bug for FF3.1 theming issues?
Flags: blocking-firefox3.1?
Summary: Drop downs on bookmarks toolbar are distorted for RTL locales → Drop downs for folders on bookmarks toolbar are distorted for RTL locales
>Alex, do we have a tracking bug for FF3.1 theming issues?

we are using whiteboard terms [polish-easy] or [polish-hard], as well as [polish-visual] or [polish-interactive].

Mike: this does look pretty broken, assuming it isn't much work to fix we might want to pick it up as a blocker.
Whiteboard: [polish-easy][polish-visual]
Agree that this blocks; when did it regress?
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Priority: -- → P2
Keywords: regression
Assignee

Updated

11 years ago
Regressed between the build from 0810602 and 08100902:
http://tinyurl.com/be9v3g

I highly suspect bug 438302 which operates on the text-shadow and touches the toolbar-button stack. Dao, what do you think?
Assignee

Updated

11 years ago
Assignee: nobody → dao
Blocks: 438302
Assignee

Comment 6

11 years ago
Attachment #361757 - Flags: review?(enndeakin)
Summary: Drop downs for folders on bookmarks toolbar are distorted for RTL locales → [RTL] Drop downs for folders on bookmarks toolbar are distorted for RTL locales

Updated

11 years ago
Attachment #361757 - Flags: review?(enndeakin) → review+
Assignee

Comment 7

11 years ago
http://hg.mozilla.org/mozilla-central/rev/319799933481
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3b09df245485
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.2a1
Sadly it is not fixed completely. The drop down looks fine but there is still a gap between the folder name and the drop down. See the screenshot.
Status: RESOLVED → REOPENED
Keywords: fixed1.9.1
Resolution: FIXED → ---
Assignee

Comment 10

11 years ago
Posted patch followupSplinter Review
Attachment #362383 - Flags: review?(mstange)
Attachment #362383 - Flags: review?(mstange) → review+
Assignee

Updated

11 years ago
Keywords: checkin-needed
Attachment #361757 - Attachment description: patch → patch (checked-in)

Updated

11 years ago
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fa; rv:1.9.2a1pre) Gecko/20090219 Minefield/3.2a1pre ID:20090219020624

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fa; rv:1.9.1b3pre) Gecko/20090219 Shiretoko/3.1b3pre ID:20090219020454
Status: RESOLVED → VERIFIED
Hardware: x86 → All
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.
Whiteboard: [polish-easy][polish-visual] → [polish-easy][polish-visual][polish-p2]

Updated

6 years ago
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.