477709 - [W-1.1.*] View Collection Scaffolding

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

Scaffolding: The View Collection scaffolding should display the collection name, names of all add-ons in the collection, and have a link to subscribe to the collection.

Comment 1

[Ryan Doherty (:rdoherty)]

Attachment: Patch for sanity checking

Comment 2

[Les Orchard [:lorchard]]

Comment on attachment 361812 [details] [diff] [review]
Patch for sanity checking

Hmm... I can't seem to apply this patch.  It seems to expect that a file exists at site/app/views/collections/view.thtml

But, I don't see it in the HEAD revision of this branch:

https://svn.mozilla.org/addons/branches/bandwagon/site/app/views/collections/

Something seems kind of screwy :/

Comment 3

[Les Orchard [:lorchard]]

For what it's worth, I was able to apply the parts of the patch for the model, which look fine and will actually help me get further with the API work.  The controller stuff looks okay too.

Seems like the issue is with the views, and probably just that one view.thtml

Comment 4

[Ryan Doherty (:rdoherty)]

I did rename display.thtml to view.thtml, that's probably the problem. Not sure how to fix that in the patch though...

Comment 5

[Ryan Doherty (:rdoherty)]

(In reply to comment #4)
> I did rename display.thtml to view.thtml, that's probably the problem. Not sure
> how to fix that in the patch though...

That was a `svn mv ` command.

Comment 6

[Ryan Doherty (:rdoherty)]

I've committed the patch in r22193 since Les ok'd most of the code and it will allow him to review it easily.

Les, if there's changes needed, let me know.

Comment 7

[Les Orchard [:lorchard]]

Looks fine to me after an svn up!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED (scope of scaffolding *only*) on https://preview.addons.mozilla.org/en-US/firefox/collections/view/787694ee-692f-102c-9a23-001e0bd9232c.