477712 - [W-1.3.*] Collection Creation Scaffolding

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

Scaffolding: The collection creation form should have fields for the collection name, description, and whether it is listed in the directory. The collection ID should be auto-generated upon creation.

Comment 1

[Ryan Doherty (:rdoherty)]

Attachment: Collection creation patch

Collection creation scaffolding. Very simple, just needs a sanity check to verify nothing is horribly wrong. Frontend code will be rewritten.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: Patch with views

Forgot to add the views.

Comment 3

[Les Orchard [:lorchard]]

Comment on attachment 361566 [details] [diff] [review]
Patch with views

When I try this, I get this SQL error and no new row is added to the collections table:

Warning: SQL Error: 1452: Cannot add or update a child row: a foreign key constraint fails (`remora/collections`, CONSTRAINT `collections_addontype_ibfk_1` FOREIGN KEY (`addontype_id`) REFERENCES `addontypes` (`id`))

Additionally, it looks like the insert generated by the model is missing a user_id:

INSERT INTO `collections` (`name`,`listed`,`description`,`created`,`modified`) VALUES (295974,1,295975,'2009-02-10 16:16:05','2009-02-10 16:16:05')

Comment 4

[Ryan Doherty (:rdoherty)]

Attachment: fixed patch

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: new patch with views

Comment 6

[Les Orchard [:lorchard]]

Comment on attachment 361636 [details] [diff] [review]
new patch with views

Applied the patch, added a few collections, everything looks good now!

Comment 7

[Ryan Doherty (:rdoherty)]

r22136

Comment 8

[Justin Scott [:fligtar]]

The new SQL has been run on production and staging, but I can't seem to create a collection. Ryan, would you mind looking into this?

https://bandwagon.stage.mozilla.com/en-US/firefox/collections/add

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Scaffolding verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collections/add/; we're able to create collections now, so comment 8 WFM.