Closed Bug 477747 Opened 13 years ago Closed 13 years ago

app cache "noupdate" event fired too early for master entries

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch v1Splinter Review
When a manifest update is triggered by a master entry (an entry that includes the manifest attribute but was not explicitly listed in the manifest itself), we schedule a partial update to add the master entry to the application cache, and then fire a "noupdate" event.  The spec says that we should fire noupdate after the master entry has been successfully added to the cache.

The attached patch fixes this by having the main update manage/run the partial update, rather than scheduling it with the main service.

This patch also correctly associates pending master documents before scheduling the partial update.  That bit is really small, and if we end up not wanting the whole thing for 3.1, I'll spin that into a new bug.
Flags: blocking1.9.1?
Attachment #361460 - Flags: superreview?(jst)
Attachment #361460 - Flags: review?(jst)
Not blocking, jst said he'd review the patch.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Attachment #361460 - Flags: superreview?(jst)
Attachment #361460 - Flags: superreview+
Attachment #361460 - Flags: review?(jst)
Attachment #361460 - Flags: review+
Attachment #361460 - Flags: approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/06ec9c2f02a6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 482370
An approval of this patch should also include an approval of the regression fix in bug 482370
Comment on attachment 361460 [details] [diff] [review]
v1

a191=beltzner
Attachment #361460 - Flags: approval1.9.1? → approval1.9.1+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.