477866 - Updated chatzilla.jar and chatzilla-service.js to this year's version but now chat won't launch

Status: RESOLVED INVALID

(Other Applications Graveyard :: QA Companion, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

I updated the chatzilla.jar and chatzilla-service.js in QAC to the ChatZilla 0.9.84, which is a year (and many bugfixes) later than the version we had before.

Updating just the jar, I received the error: 

XML Parsing Error: undefined entity
Location: chrome://chatzilla_qa/content/chatzilla.xul
Line Number 120, Column 7:      <button id="server-nick" type="menu" label="" tooltiptext="&server-nick.tooltip;"/>
------^

on launch so I added the chatzilla-service.js as well.

Now, when I attempt to launch chat within my test build of QAC, nothing happens at all. No error messages but no chatzilla window either.

Revisiona 22129 and 22130.

Any ideas?

Comment 1

[Al Billings [:abillings - ex-MoCo]]

Error console does show:

No chrome package registered for chrome://chatzilla/content/chatzilla.xul

Comment 2

[Al Billings [:abillings - ex-MoCo]]

Within the chatzilla.jar file, there is a /content/chatzilla/chatzilla.xul

Is this just a path problem with the new jar file and I need to update /jar-chrome.manifest to match the new path?

Comment 3

[cmtalbert]

No, that is the same structure as the old jar so the existing manifest files should work.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Attachment: diff of chatzilla-services.js changes

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Attachment: new chatzilla.jar file with _qa added to chrome://chatzilla

Comment 6

[Al Billings [:abillings - ex-MoCo]]

Attachment: chatzilla-service changes

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Still get this error when I try chat in QAC if I look in the error console:

Error: spawnChatZilla is not defined
Source File: chrome://chatzillaservice_qa/content/chatzilla-service.js
Line: 151

I'm not sure why it is looking in chatzillaservice_qa/content/chatzilla-service.js for components/chatzilla-service.js (it isn't in the chatzilla.jar file and there is no chatzillaservice_qa.jar file. I suspect I screwed up a search and replace).

Comment 8

[Al Billings [:abillings - ex-MoCo]]

I had a bad search and replace, which I've fixed.

When I try to launch chat now, nothing happens. If you close QAC, the error console will eventually show:

Error: spawnChatZilla is not defined
Source File: chrome://chatzillaservice/content/chatzilla-service.js
Line: 151

That is part of:

 if ("ChatZillaStarting" in hiddenWin)
    {
        count = count || 0;

        if ((new Date() - hiddenWin.ChatZillaStarting) > 10000)
        {
            dump("cz-service: Continuing to be unable to talk to existing window!\n");
        }
        else
        {
            //dump("cz-service: **** Try: " + count + ", delay: " + (new Date() - hiddenWin.ChatZillaStarting) + "\n");

            // We have a ChatZilla window, but we're still loading.
            hiddenWin.setTimeout(function wrapper(count) {
                    spawnChatZilla(uri, count + 1);
                }, 250, count);
            return true;
        }
    }

but that function is defined on line 110.

I'm updating my diff of changes (except for the jar changes, which cannot be diffed but which are attached).

Comment 9

[Al Billings [:abillings - ex-MoCo]]

Attachment: Diff of my changes to QAC excluding the chatzilla.jar

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Attachment: Diff of my changes to QAC excluding the chatzilla.jar

Comment 11

[Al Billings [:abillings - ex-MoCo]]

This is fubar'd. Backing it all out and doing it right later.