477908 - Set a smaller value for DOWNLOAD_BACKGROUND_INTERVAL for non official builds

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

When downloading an complete update for a nightly build the interval is way too long and will take hours (around 5?) to complete and often it will be the next day before the download has completed. By changing DOWNLOAD_BACKGROUND_INTERVAL from 600 to 60 for non official builds (e.g. nightly builds) the approximate time to complete should be under an hour.

Comment 1

[Robert Strong (they/them - no direct email)]

Probably best to key on either the channel or official branding.

Comment 2

[Robert Strong (they/them - no direct email)]

or MOZILLA_OFFICIAL

Comment 3

[Phil Ringnalda (:philor)]

MOZILLA_OFFICIAL means "anything built on any Mozilla tinderbox" so you don't want that.

Comment 4

[Robert Strong (they/them - no direct email)]

Yea... I'm a bit slow and under the weather today

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

If we're going down this road (and it's a good road to tread), then it'd be worth considering shortening app.update.interval too. The default check of once a day means you end up with more complete updates than is convenient for frequent nightly use. We'd have to check if that'd impact on metrics though.

Comment 6

[Robert Strong (they/them - no direct email)]

I shortened the interval for nightly builds awhile ago to 8 hours
http://mxr.mozilla.org/mozilla-central/source/browser/app/firefox-branding.js#5
http://mxr.mozilla.org/mozilla-central/source/browser/branding/unofficial/pref/firefox-branding.js#5

Comment 7

[Robert Strong (they/them - no direct email)]

and I notified metrics when I made the change

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Pardon me, I really should pay more attention. That was in Bug 324121 ftr.

Comment 9

[Robert Strong (they/them - no direct email)]

No worries

Comment 10

[Dave Miller [:justdave]]

This is only affecting nightly builds and not releases, right?

Comment 11

[Robert Strong (they/them - no direct email)]

correct

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

I went with a pref since other apps may want to specify a custom value.

Comment 13

[Robert Strong (they/them - no direct email)]

I'll land this after the mozilla-central tree is in better shape.

btw: I gave Justin a heads up about this change for nightly updates as well.

Comment 14

[Robert Strong (they/them - no direct email)]

cc'ing a bunch of people in case they are interested in adding this pref for their app updates.

Comment 15

[Jesse Ruderman]

It seems wrong for this to depend on branding (rather than, say, channel).  I think depending on branding will make alphas behave like nightlies and betas behave like releases, which might not be what we want.

Comment 16

[Robert Strong (they/them - no direct email)]

Well, the pref can be set to whatever number and for whatever type of build it wants and if an app chooses not to we fallback to the number of seconds we've been using. I agree that it *might* be nice to have a new way of setting this but that can be said about several of the prefs set in the branding prefs file as well as other code that is different based on the type of build.

Comment 17

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/e6d08d303d53