Closed Bug 477936 Opened 12 years ago Closed 12 years ago

The first argument of g_signal_XX functions is a gpointer so G_OBJECT macros is not needed in moz-web-view.cpp.

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hiro, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.8.0.4) Gecko/20060508 Firefox/3.0
Build Identifier: 

The first argument of g_signal_XX functions is a gpointer so G_OBJECT macros is not needed in moz-web-view.cpp.

Reproducible: Always
Attached patch A patch (obsolete) — Splinter Review
Attachment #361692 - Flags: review?(mark.finkle)
Comment on attachment 361692 [details] [diff] [review]
A patch

bug 455247 fixed some of these. I don't think it fixed all of them.

If this is still an issue, can you make a new patch?
Attachment #361692 - Flags: review?(mark.finkle) → review-
(In reply to comment #2)
> (From update of attachment 361692 [details] [diff] [review])
> bug 455247 fixed some of these. I don't think it fixed all of them.
> 
> If this is still an issue, can you make a new patch?

Yes, sure.
Bu I can't see any change in http://hg.mozilla.org/incubator/embedding/rev/0daaac93ea35
Attached patch update patchSplinter Review
This is it.
Attachment #361692 - Attachment is obsolete: true
Attachment #369442 - Flags: review?(mark.finkle)
Comment on attachment 369442 [details] [diff] [review]
update patch

hmm, I notice that moz_web_view_hierarchy_changed is not in the x11 files.
Attachment #369442 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/incubator/embedding/rev/0567bf985e06
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.