477936 - The first argument of g_signal_XX functions is a gpointer so G_OBJECT macros is not needed in moz-web-view.cpp.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.8.0.4) Gecko/20060508 Firefox/3.0
Build Identifier: 

The first argument of g_signal_XX functions is a gpointer so G_OBJECT macros is not needed in moz-web-view.cpp.

Reproducible: Always

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 361692 [details] [diff] [review]
A patch

bug 455247 fixed some of these. I don't think it fixed all of them.

If this is still an issue, can you make a new patch?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #2)
> (From update of attachment 361692 [details] [diff] [review])
> bug 455247 fixed some of these. I don't think it fixed all of them.
> 
> If this is still an issue, can you make a new patch?

Yes, sure.
Bu I can't see any change in http://hg.mozilla.org/incubator/embedding/rev/0daaac93ea35

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Yeah, I messed up the push. Try http://hg.mozilla.org/incubator/embedding/rev/a6038143acd0

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: update patch

This is it.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 369442 [details] [diff] [review]
update patch

hmm, I notice that moz_web_view_hierarchy_changed is not in the x11 files.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/incubator/embedding/rev/0567bf985e06