Closed Bug 477936 Opened 12 years ago Closed 12 years ago
The first argument of g
_signal _XX functions is a gpointer so G _OBJECT macros is not needed in moz-web-view .cpp .
User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:188.8.131.52) Gecko/20060508 Firefox/3.0 Build Identifier: The first argument of g_signal_XX functions is a gpointer so G_OBJECT macros is not needed in moz-web-view.cpp. Reproducible: Always
Comment on attachment 361692 [details] [diff] [review] A patch bug 455247 fixed some of these. I don't think it fixed all of them. If this is still an issue, can you make a new patch?
Attachment #361692 - Flags: review?(mark.finkle) → review-
(In reply to comment #2) > (From update of attachment 361692 [details] [diff] [review]) > bug 455247 fixed some of these. I don't think it fixed all of them. > > If this is still an issue, can you make a new patch? Yes, sure. Bu I can't see any change in http://hg.mozilla.org/incubator/embedding/rev/0daaac93ea35
Yeah, I messed up the push. Try http://hg.mozilla.org/incubator/embedding/rev/a6038143acd0
This is it.
Comment on attachment 369442 [details] [diff] [review] update patch hmm, I notice that moz_web_view_hierarchy_changed is not in the x11 files.
Attachment #369442 - Flags: review?(mark.finkle) → review+
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.