Sort Folder dialog lacks accesskeys

RESOLVED FIXED in seamonkey2.0a3

Status

SeaMonkey
Bookmarks & History
--
minor
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: wladow, Assigned: wladow)

Tracking

({access, polish})

Trunk
seamonkey2.0a3
access, polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 361781 [details] [diff] [review]
add accesskeys, v1

Bookmark Manager -> Edit -> Sort Folder dialog lacks accesskeys
Attachment #361781 - Flags: superreview?(neil)
Attachment #361781 - Flags: review?(neil)

Updated

10 years ago
Attachment #361781 - Flags: superreview?(neil)
Attachment #361781 - Flags: superreview+
Attachment #361781 - Flags: review?(neil)
Attachment #361781 - Flags: review+

Comment 1

10 years ago
Comment on attachment 361781 [details] [diff] [review]
add accesskeys, v1

> <!ENTITY sortBy.label "Sort by:">
>+<!ENTITY sortBy.accesskey "S">
> <!ENTITY sortBy.name.label "Name">
> <!ENTITY sortBy.url.label "Location">
> <!ENTITY sortBy.shortcutUrl.label "Keyword">
>@@ -13,8 +14,11 @@
> <!ENTITY sortBy.lastVisitDate.label "Last Visited">
> 
> <!ENTITY sortOrder.label "Sort order:">
>+<!ENTITY sortOrder.accesskey "o">
> <!ENTITY sortAscending.label "Ascending">
> <!ENTITY sortDescending.label "Descending">
> 
> <!ENTITY sortFoldersFirst.label "Sort folders first">
>+<!ENTITY sortFoldersFirst.accesskey "d">
> <!ENTITY sortRecursively.label "Sort recursively">
>+<!ENTITY sortRecursively.accesskey "e">
I think I'd prefer c rather than e here. I'm not so sure about Sort folders first though; I can see that the only reasonable access keys are s, o and d and the first two are already taken :-( so possibly it might be worth changing Sort by's key to b thus freeing up S?
(Assignee)

Comment 2

10 years ago
Created attachment 361785 [details] [diff] [review]
for checkin
[Checkin: Comment 3]

> I think I'd prefer c rather than e here.
done.

> I'm not so sure about Sort folders first though; 
> I can see that the only reasonable access keys are s, o and d and
> the first two are already taken :-( so possibly it might be worth changing Sort
> by's key to b thus freeing up S?

No, for a better readability we should avoid (where possible) using a character, which is followed by characters like 'y', 'j', 'g' etc.
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Comment on attachment 361785 [details] [diff] [review]
for checkin
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/7e697839825f
Attachment #361785 - Attachment description: for checkin → for checkin [Checkin: Comment 3]
Attachment #361781 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.