Closed
Bug 478025
Opened 15 years ago
Closed 15 years ago
Sort Folder dialog lacks accesskeys
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a3
People
(Reporter: wladow, Assigned: wladow)
Details
(Keywords: access, polish)
Attachments
(1 file, 1 obsolete file)
2.57 KB,
patch
|
Details | Diff | Splinter Review |
Bookmark Manager -> Edit -> Sort Folder dialog lacks accesskeys
Attachment #361781 -
Flags: superreview?(neil)
Attachment #361781 -
Flags: review?(neil)
Updated•15 years ago
|
Attachment #361781 -
Flags: superreview?(neil)
Attachment #361781 -
Flags: superreview+
Attachment #361781 -
Flags: review?(neil)
Attachment #361781 -
Flags: review+
Comment 1•15 years ago
|
||
Comment on attachment 361781 [details] [diff] [review] add accesskeys, v1 > <!ENTITY sortBy.label "Sort by:"> >+<!ENTITY sortBy.accesskey "S"> > <!ENTITY sortBy.name.label "Name"> > <!ENTITY sortBy.url.label "Location"> > <!ENTITY sortBy.shortcutUrl.label "Keyword"> >@@ -13,8 +14,11 @@ > <!ENTITY sortBy.lastVisitDate.label "Last Visited"> > > <!ENTITY sortOrder.label "Sort order:"> >+<!ENTITY sortOrder.accesskey "o"> > <!ENTITY sortAscending.label "Ascending"> > <!ENTITY sortDescending.label "Descending"> > > <!ENTITY sortFoldersFirst.label "Sort folders first"> >+<!ENTITY sortFoldersFirst.accesskey "d"> > <!ENTITY sortRecursively.label "Sort recursively"> >+<!ENTITY sortRecursively.accesskey "e"> I think I'd prefer c rather than e here. I'm not so sure about Sort folders first though; I can see that the only reasonable access keys are s, o and d and the first two are already taken :-( so possibly it might be worth changing Sort by's key to b thus freeing up S?
Assignee | ||
Comment 2•15 years ago
|
||
> I think I'd prefer c rather than e here. done. > I'm not so sure about Sort folders first though; > I can see that the only reasonable access keys are s, o and d and > the first two are already taken :-( so possibly it might be worth changing Sort > by's key to b thus freeing up S? No, for a better readability we should avoid (where possible) using a character, which is followed by characters like 'y', 'j', 'g' etc.
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 3•15 years ago
|
||
Comment on attachment 361785 [details] [diff] [review] for checkin [Checkin: Comment 3] http://hg.mozilla.org/comm-central/rev/7e697839825f
Attachment #361785 -
Attachment description: for checkin → for checkin
[Checkin: Comment 3]
Updated•15 years ago
|
Attachment #361781 -
Attachment is obsolete: true
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•